Page MenuHomePhabricator

Add type parameter to ModifyUITemplate function calls
Closed, ResolvedPublic

Description

I would like my authentication hook to be able to modify the UI differently
depending on whether the user is trying to log in or create a new account. To
do this, I added a parameter to the abstract function
AuthPlugin::modifyUITemplate() for the login type. In SpecialUserlogin.php
around line 687 I added $this->mType as the second parameter in the
modifyUITemplate call. I think this would be useful for others modifying the UI
as well and would be useful if added to the code base.


Version: 1.10.x
Severity: enhancement
URL: http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/SpecialUserlogin.php?view=markup

Details

Reference
bz9691

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:39 PM
bzimport set Reference to bz9691.
bzimport added a subscriber: Unknown Object (MLST).

Fix against 11.0 release

As described above, adds type parameter to abstract function AuthPlugin->modifyUITemplate and passes parameter to the call to modifyUITemplate in SpecialUserlogin.php

Attached:

Applied in r53843