Page MenuHomePhabricator
Create Task
Maniphest T116970

CirrusSearch\Hooks::onTitleMoveComplete throwing exceptions on all moves on MediaWiki.org
Closed, ResolvedPublic
Actions

Description

The moves still go through, but the user sees an error page.

2015-10-28 21:37:22 mw1060 mediawikiwiki exception ERROR: [d967336e] /w/index.php?title=Special:MovePage&action=submit   MWException from line 223 of /srv/mediawiki/php-1.27.0-wmf.4/includes/Hooks.php: Detected bug in an extension! Hook CirrusSearch\Hooks::onTitleMoveComplete has invalid call signature; Parameter 3 to CirrusSearch\Hooks::onTitleMoveComplete() expected to be a reference, value given {"exception_id":"d967336e"} 
[Exception MWException] (/srv/mediawiki/php-1.27.0-wmf.4/includes/Hooks.php:223) Detected bug in an extension! Hook CirrusSearch\Hooks::onTitleMoveComplete has invalid call signature; Parameter 3 to CirrusSearch\Hooks::onTitleMoveComplete() expected to be a reference, value given
  #0 /srv/mediawiki/php-1.27.0-wmf.4/includes/MovePage.php(376): Hooks::run(string, array)
  #1 /srv/mediawiki/php-1.27.0-wmf.4/includes/db/Database.php(3310): Closure$MovePage::move()
  #2 /srv/mediawiki/php-1.27.0-wmf.4/includes/db/Database.php(3557): DatabaseBase->runOnTransactionIdleCallbacks()
  #3 /srv/mediawiki/php-1.27.0-wmf.4/includes/db/loadbalancer/LoadBalancer.php(1039): DatabaseBase->commit(string, string)
  #4 /srv/mediawiki/php-1.27.0-wmf.4/includes/db/loadbalancer/LBFactory.php(186): LoadBalancer->commitMasterChanges()
  #5 /srv/mediawiki/php-1.27.0-wmf.4/includes/db/loadbalancer/LBFactoryMulti.php(397): Closure$LBFactory::forEachLBCallMethod(LoadBalancer, string, array)
  #6 /srv/mediawiki/php-1.27.0-wmf.4/includes/db/loadbalancer/LBFactory.php(187): LBFactoryMulti->forEachLB(Closure$LBFactory::forEachLBCallMethod;1384005219, array)
  #7 /srv/mediawiki/php-1.27.0-wmf.4/includes/db/loadbalancer/LBFactory.php(204): LBFactory->forEachLBCallMethod(string)
  #8 /srv/mediawiki/php-1.27.0-wmf.4/includes/MediaWiki.php(501): LBFactory->commitMasterChanges()
  #9 /srv/mediawiki/php-1.27.0-wmf.4/includes/MediaWiki.php(674): MediaWiki->doPreOutputCommit()
  #10 /srv/mediawiki/php-1.27.0-wmf.4/includes/MediaWiki.php(474): MediaWiki->main()
  #11 /srv/mediawiki/php-1.27.0-wmf.4/index.php(41): MediaWiki->run()
  #12 /srv/mediawiki/w/index.php(3): include(string)
  #13 {main}

Original report:

I used Special:EnableFlow to convert https://www.mediawiki.org/wiki/Talk:WMF_Product_Development_Process (which had one edit on it).
The special page gave me this error:

An error occurred.
The error message received was: Detected bug in an extension! Hook CirrusSearch\Hooks::onTitleMoveComplete has invalid call signature; Parameter 3 to CirrusSearch\Hooks::onTitleMoveComplete() expected to be a reference, value given

(screenshot below)
The page was moved correctly, to https://www.mediawiki.org/wiki/Talk:WMF_Product_Development_Process/Archive_1
but the page was not converted to Flow.

4qQse3n.png (845×913 px, 45 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Revert "Remove ampersands from onTitleMoveComplete()"mediawiki/extensions/CirrusSearchmaster+1 -1
Customize query in gerrit

Event Timeline

Quiddity created this task.Oct 28 2015, 9:00 PM
Quiddity raised the priority of this task from to Unbreak Now!.
Quiddity updated the task description. (Show Details)
Quiddity added projects: StructuredDiscussions, Collaboration-Team-Archive-2015-2016.
Quiddity added subscribers: Quiddity, Trizek-WMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2015, 9:00 PM
Quiddity added a comment.Oct 28 2015, 9:33 PM

Confirmed/reproduced at https://www.mediawiki.org/wiki/User_talk:Quiddity_(WMF)/sandbox7
Nothing obvious in webconsole.

Screenshot from 2015-10-28 14:31:00.png (930×1,058 px, 241 KB)

• Mattflaschen-WMF renamed this task from Error converting a page to Flow - CirrusSearch\Hooks::onTitleMoveComplete to CirrusSearch\Hooks::onTitleMoveComplete throwing exceptions on all moves on MediaWiki.org.Oct 28 2015, 9:39 PM
• Mattflaschen-WMF edited projects, added: CirrusSearch; removed: Collaboration-Team-Archive-2015-2016, StructuredDiscussions.
• Mattflaschen-WMF set Security to None.
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptOct 28 2015, 9:39 PM
• Mattflaschen-WMF updated the task description. (Show Details)Oct 28 2015, 9:40 PM
• Mattflaschen-WMF assigned this task to aaron.Oct 28 2015, 9:45 PM
• Mattflaschen-WMF subscribed.

This is being worked on : https://gerrit.wikimedia.org/r/#/c/249189/

• Mattflaschen-WMF added a project: Performance-Team.Oct 28 2015, 9:46 PM
• Mattflaschen-WMF claimed this task.Oct 28 2015, 9:49 PM
• Mattflaschen-WMF added a subscriber: aaron.

Never mind, I misread that as 5:41 today.

gerritbot subscribed.Oct 28 2015, 9:52 PM

Change 249571 had a related patch set uploaded (by Mattflaschen):
Revert "Remove ampersands from onTitleMoveComplete()"

https://gerrit.wikimedia.org/r/249571

gerritbot added a project: Patch-For-Review.Oct 28 2015, 9:52 PM
gerritbot added a comment.Oct 28 2015, 9:56 PM

Change 249571 merged by jenkins-bot:
Revert "Remove ampersands from onTitleMoveComplete()"

https://gerrit.wikimedia.org/r/249571

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)).Oct 28 2015, 10:00 PM
• Mattflaschen-WMF removed • Mattflaschen-WMF as the assignee of this task.Oct 28 2015, 11:25 PM
aaron added a comment.Oct 28 2015, 11:37 PM

Last of any of these errors (it affected a few extensions) was 2015-10-28T23:19:39.445Z. I can now move mw.org pages without error as of the I0e5f2d deploy.

The root cause is still there and might be some sort of HHVM bug causing one of the reference arguments to be seen as a value.

Quiddity lowered the priority of this task from Unbreak Now! to Needs Triage.Oct 29 2015, 12:04 AM

Page moves (tested by aaron), and Special:EnableFlow (tested by me), are both working fine now, so I'll un-set the priority.

EBernhardson closed this task as Resolved.Oct 29 2015, 4:41 PM
• Deskana moved this task from Inbox to Resolved/Invalid/Declined/Legacy on the CirrusSearch board.Dec 31 2015, 5:07 AM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptDec 31 2015, 5:07 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits