Page MenuHomePhabricator
Create Task
Maniphest T117085

Search regression - tapping on search suggestion does nothing
Closed, ResolvedPublic
Actions

Description

Observed in alpha build 454

Repro:

  • search for "foodz"
  • tap on "did you mean food"

Screen Shot 2015-10-29 at 12.37.31 PM.png (1×675 px, 140 KB)

Related Objects

Event Timeline

Mhurd created this task.Oct 29 2015, 7:38 PM
Mhurd raised the priority of this task from to Needs Triage.
Mhurd updated the task description. (Show Details)
Mhurd added a project: Wikipedia-iOS-App-Development.
Mhurd moved this task to Tasks from Product Backlog on the Wikipedia-iOS-App-Development board.
Mhurd added subscribers: Mhurd, iOS-app-v5-beta.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2015, 7:38 PM
Mhurd added a comment.Oct 29 2015, 7:38 PM

Per Josh tagged beta and placed atop ready for dev.

• JMinor renamed this task from Search regression - tapping on search suggestion does nothing to Search regression - tapping on search suggestion does nothing .Oct 29 2015, 10:18 PM
• JMinor triaged this task as High priority.
• JMinor updated the task description. (Show Details)
• JMinor added a project: iOS-app-v5-beta.
• JMinor set Security to None.
• JMinor removed a subscriber: iOS-app-v5-beta.
• Fjalapeno moved this task from Tasks from Product Backlog to Doing on the Wikipedia-iOS-App-Development board.Oct 30 2015, 3:10 PM
• Fjalapeno claimed this task.Oct 30 2015, 4:42 PM
• Fjalapeno moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Development board.
Diffusion mentioned this in rAPIOS00831bd4832c: Merge pull request #217 from wikimedia/feature/T117085/search-suggestion.Oct 30 2015, 5:49 PM
Mhurd moved this task from Needs Code Review to Needs QA on the Wikipedia-iOS-App-Development board.Oct 30 2015, 5:53 PM
Etonkovidova subscribed.Oct 30 2015, 10:49 PM

Another case to check after the fix:

  • type "srar"
  • "Did you mean srair?" - no search results and no indication that the search is done.

In wiki 'srair' search will bring "Sanhaja de Srair language" article.

IMG_0039 (1).PNG (1×640 px, 102 KB)

Etonkovidova added a comment.Nov 2 2015, 6:25 PM

Checked with 5.0.0.454 - the issue is still present.

Etonkovidova added a comment.Nov 3 2015, 8:44 PM

Checked with 5.0.0.465 on iPhone 5 iOS 9.02

The issue with 'srar' is split into a separate bug T117601: [Regression 5.0.0.465] Search suggestion does not work for some search criteria .

Etonkovidova moved this task from Needs QA to Ready for PM Signoff on the Wikipedia-iOS-App-Development board.Nov 3 2015, 8:45 PM
• JMinor closed this task as Resolved.Nov 18 2015, 8:30 PM
• JMinor subscribed.

We're still having regressions around search, but will use follow-up tickets for those. As of Alpha 501, this particular issue is fixed.

Diffusion mentioned this in rAPIOS71e53f4e1bbf: Merge pull request #217 from wikimedia/feature/T117085/search-suggestion.Dec 28 2015, 9:11 PM
thcipriani mentioned this in T114320: Code-review migration to Differential status/discussion.Jan 4 2016, 7:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits