Page MenuHomePhabricator

[Placeholder] Related articles should be dependent on Cards
Closed, ResolvedPublic

Details

Related Gerrit Patches:
mediawiki/extensions/RelatedArticles : devMake RelatedArticles soft-depend on Cards
mediawiki/extensions/Cards : masterSimplify the modules

Event Timeline

dr0ptp4kt moved this task from Backlog to Feature on the Reading-Admin board.Nov 13 2015, 12:53 AM
dr0ptp4kt moved this task from Feature to Doing on the Reading-Admin board.

@bmansurov: It might be enough to simplify the RL module layout of Cards to a single module, e.g. ext.cards, and have RelatedArticles, Gather, and, eventually, MobileFrontend modules depend on it.

Change 252919 had a related patch set uploaded (by Bmansurov):
Simplify the modules

https://gerrit.wikimedia.org/r/252919

^ Simplified the modules. Let's get this reviewed so that we can start working on making RelatedArticles can depend on Cards.

The -hhvm build is failing because of a target mismatch between a module and its test module.

Reviewing despite the above…

@bmansurov: There's a small amount of work to be done around fixing up all of the JSDuck warnings that are introduced. See my latest comment on 252919.

Change 252919 merged by jenkins-bot:
Simplify the modules

https://gerrit.wikimedia.org/r/252919

I thought we agreed that we won't be adding watchstars in this iteration.

I thought we agreed that we won't be adding watchstars in this iteration.

What's this in response to @bmansurov?

It's just a comment that accompanies my action of removing T116624 from the blocking tasks list.

Change 253318 had a related patch set uploaded (by Bmansurov):
Make RelatedArticles soft-depend on Cards

https://gerrit.wikimedia.org/r/253318

Change 253318 merged by jenkins-bot:
Make RelatedArticles soft-depend on Cards

https://gerrit.wikimedia.org/r/253318

You can see (in the dev tools) that the cards extension is being loaded and used in http://reading-web-staging.wmflabs.org/w/index.php?title=1&mobileaction=toggle_view_mobile

phuedx closed this task as Resolved.Nov 23 2015, 9:57 AM