Page MenuHomePhabricator
Create Task
Maniphest T117117

Add a warning about choosing a date in the future
Closed, ResolvedPublic
Actions

Description

After T96917, it should be super easy to add new warnings and errors and such. Let's try adding a warning about the user inputting a file creation date that is in the future (it's not a hard error, the user might have the date misconfigured on their system, or the date might come from a timezone where it already is tomorrow).

Details

SubjectRepoBranchLines +/-
Warning when file date is in the futuremediawiki/extensions/UploadWizardmaster+16 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Oct 29 2015, 10:40 PM
matmarex raised the priority of this task from to Medium.
matmarex updated the task description. (Show Details)
matmarex added projects: UploadWizard, good first task, Google-Code-In-2015.
matmarex subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptOct 29 2015, 10:40 PM
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald Transcript
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Nov 5 2015, 6:30 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptNov 5 2015, 6:30 PM
rkgudboy subscribed.Nov 15 2015, 8:54 PM

I will mentor this in #GCI2015

Aklapper added a comment.Nov 24 2015, 11:36 AM

matmarex will mentor this task, as mentors must be community members already.

matmarex added a comment.Dec 3 2015, 9:38 PM

https://codein.withgoogle.com/dashboard/tasks/5341894095667200/

Aklapper moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.Dec 4 2015, 3:52 PM
Sn1per claimed this task.Dec 7 2015, 9:43 PM
Sn1per subscribed.

Another year of Google-Code-In-2015!

gerritbot subscribed.Dec 8 2015, 10:09 PM

Change 257760 had a related patch set uploaded (by Sn1per):
Warning when file date is in the future

https://gerrit.wikimedia.org/r/257760

gerritbot added a project: Patch-For-Review.Dec 8 2015, 10:09 PM
matmarex changed the task status from Open to Stalled.Dec 9 2015, 3:27 AM
matmarex added a subtask: T120905: Generalize the warning system, improve warning handling.

(Patch is great, but I realised that we really should do T120905 before merging it.)

matmarex closed this task as Resolved.Dec 20 2015, 1:46 AM
matmarex closed subtask T120905: Generalize the warning system, improve warning handling as Resolved.
matmarex removed a project: Patch-For-Review.
matmarex set Security to None.
gerritbot added a comment.Dec 20 2015, 1:48 AM

Change 257760 merged by jenkins-bot:
Warning when file date is in the future

https://gerrit.wikimedia.org/r/257760

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Dec 20 2015, 2:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits