Page MenuHomePhabricator
Create Task
Maniphest T117121

TitleBlacklist complete error messages are utterly hopeless in UploadWizard
Closed, ResolvedPublic
Actions

Assigned To
matmarex
Authored By
matmarex
Oct 29 2015, 10:54 PM
Tags
Referenced Files
F4197757: pasted_file
Jun 24 2016, 11:51 AM
F4197747: pasted_file
Jun 24 2016, 11:51 AM
F4197760: pasted_file
Jun 24 2016, 11:51 AM
F4197751: pasted_file
Jun 24 2016, 11:51 AM
F2893795: pasted_file
Oct 29 2015, 10:54 PM
F2893791: pasted_file
Oct 29 2015, 10:54 PM
Subscribers
Aklapper
gerritbot
Matanya
matmarex
Steinsplitter

Description

TitleBlacklist complete error messages are utterly hopeless in UploadWizard.

Let's say you try upload a file with a non-descriptive name:

pasted_file (947×1 px, 131 KB)

You're a curious person and you click the "More Info" link/button:
pasted_file (947×1 px, 214 KB)

OH GOD MY EYES WHAT HAVE I UNLEASHED

Details

SubjectRepoBranchLines +/-
mw.errorDialog: Make the error message dialog largermediawiki/extensions/UploadWizardmaster+15 -13
uw.TitleDetailsWidget: Parse TitleBlacklist messagesmediawiki/extensions/UploadWizardmaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Oct 29 2015, 10:54 PM
matmarex raised the priority of this task from to Medium.
matmarex updated the task description. (Show Details)
matmarex added a project: UploadWizard.
matmarex subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptOct 29 2015, 10:54 PM
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald Transcript
matmarex added a subtask: T115259: Commons' TitleBlacklist messages are messy and not parseable by jqueryMsg.Oct 29 2015, 10:54 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptOct 29 2015, 10:54 PM
Jdforrester-WMF moved this task from Untriaged to Next up on the Multimedia board.Nov 5 2015, 4:07 PM
matmarex mentioned this in T115259: Commons' TitleBlacklist messages are messy and not parseable by jqueryMsg.Jun 23 2016, 8:59 AM
gerritbot subscribed.Jun 23 2016, 9:31 AM

Change 295638 had a related patch set uploaded (by Bartosz Dziewoński):
uw.TitleDetailsWidget: Parse TitleBlacklist messages

https://gerrit.wikimedia.org/r/295638

gerritbot added a project: Patch-For-Review.Jun 23 2016, 9:31 AM
gerritbot added a comment.Jun 24 2016, 11:51 AM

Change 295897 had a related patch set uploaded (by Bartosz Dziewoński):
mw.errorDialog: Make the error message dialog larger

https://gerrit.wikimedia.org/r/295897

matmarex added a comment.Jun 24 2016, 11:51 AM

Final effect:

pasted_file (946×1 px, 169 KB)

The size of dialogs after the second patch:

BeforeAfter
TitleBlacklist error
pasted_file (946×1 px, 182 KB)
pasted_file (946×1 px, 169 KB)
Other error
pasted_file (946×1 px, 76 KB)
pasted_file (946×1 px, 74 KB)
matmarex claimed this task.Jun 24 2016, 11:52 AM
matmarex closed subtask T115259: Commons' TitleBlacklist messages are messy and not parseable by jqueryMsg as Resolved.Jun 25 2016, 8:14 PM
gerritbot added a comment.Jun 28 2016, 12:58 PM

Change 295638 merged by jenkins-bot:
uw.TitleDetailsWidget: Parse TitleBlacklist messages

https://gerrit.wikimedia.org/r/295638

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-28_(1.28.0-wmf.8)).Jun 28 2016, 1:00 PM
gerritbot added a comment.Jun 28 2016, 1:05 PM

Change 295897 merged by jenkins-bot:
mw.errorDialog: Make the error message dialog larger

https://gerrit.wikimedia.org/r/295897

matmarex closed this task as Resolved.Jun 28 2016, 3:10 PM
matmarex removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL