Page MenuHomePhabricator
Create Task
Maniphest T117140

Upstream Schema.js from MobileFrontend to EventLogging
Closed, ResolvedPublic
Actions

Description

Related Articles would like to log some events. MobileFrontend already has the Schama class which can be used by Related Articles too. This change would allow us not to pull code from MobileFrontend when the user is viewing the desktop site.

Schema.js should be updated to be an OOjs class and packaged in EventLogging. This would provide a common frontend API for beacon support and logging to servers and handling things such as sampling.

This would be useful for RelatedArticles, Gather, MobileFrontend and QuickSurveys

Details

SubjectRepoBranchLines +/-
Add Schema classmediawiki/extensions/EventLoggingmaster+125 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bmansurov created this task.Oct 30 2015, 12:11 AM
• bmansurov raised the priority of this task from to Needs Triage.
• bmansurov updated the task description. (Show Details)
• bmansurov added projects: MobileFrontend, MediaWiki-extensions-EventLogging, RelatedArticles.
• bmansurov subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2015, 12:11 AM
• bmansurov added a parent task: T114303: Add EventLogging to read more.Oct 30 2015, 12:21 AM
Jdlrobson merged a task: T109398: MobileFrontend's schema code should be upstreamed to EventLogging.Oct 30 2015, 3:15 PM
Jdlrobson added a parent task: T71366: [EPIC] Extract Minerva skin from MobileFrontend to its own repository.
Jdlrobson updated the task description. (Show Details)
Jdlrobson set Security to None.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added subscribers: Jdlrobson, • KLans_WMF, kaldari and 9 others.
Ricordisamoa unsubscribed.Oct 30 2015, 3:22 PM
• bmansurov claimed this task.Oct 30 2015, 4:49 PM
gerritbot subscribed.Oct 30 2015, 7:03 PM

Change 250057 had a related patch set uploaded (by Bmansurov):
Add Schema class

https://gerrit.wikimedia.org/r/250057

gerritbot added a project: Patch-For-Review.Oct 30 2015, 7:03 PM
Jdlrobson added a project: Reading Web Sprint 59 - Amsterdam and the hamsters.Oct 30 2015, 8:43 PM
Jdlrobson moved this task from Needs Analysis to Code Review on the Reading Web Sprint 59 - Amsterdam and the hamsters board.
Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading Web Sprint 59 - Amsterdam and the hamsters board.Oct 30 2015, 8:47 PM
Glaisher unsubscribed.Oct 31 2015, 11:38 AM
• bmansurov moved this task from -1 (Needs More Work) to Code Review on the Reading Web Sprint 59 - Amsterdam and the hamsters board.Nov 2 2015, 11:39 AM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading Web Sprint 59 - Amsterdam and the hamsters board.Nov 2 2015, 6:47 PM
phuedx added subscribers: • Nuria, phuedx.Nov 2 2015, 6:58 PM

@Nuria brings up valid concerns about storing events in $storage and logging them when the user agent fully loads the next page.

I can't remember where exactly but we've had this conversation before around MediaWiki-extensions-GettingStarted and again (including mentions of both GS and MobileFrontend) in T44815.

I guess we migrate MF to use the upstreamed class – sans navigator.sendBeacon fallback – ASAP once it's merged /cc @Jdlrobson.

Jdlrobson added a comment.Nov 2 2015, 8:24 PM

Yup. I've added a few more comments on the patchset. Baha let us know if you have any questions.

kaldari unsubscribed.Nov 2 2015, 9:03 PM
• bmansurov moved this task from -1 (Needs More Work) to Code Review on the Reading Web Sprint 59 - Amsterdam and the hamsters board.Nov 3 2015, 1:30 AM
Jdlrobson triaged this task as Medium priority.Nov 3 2015, 7:30 PM
Jdlrobson added a comment.Nov 3 2015, 11:22 PM

Waiting for some responses from @Tgr

Jdlrobson moved this task from Backlog to Team:Growth on the MobileFrontend board.Nov 4 2015, 4:47 PM
Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading Web Sprint 59 - Amsterdam and the hamsters board.Nov 6 2015, 9:58 PM
• bmansurov moved this task from -1 (Needs More Work) to Code Review on the Reading Web Sprint 59 - Amsterdam and the hamsters board.Nov 7 2015, 1:05 AM
gerritbot added a comment.Nov 7 2015, 5:25 PM

Change 250057 merged by jenkins-bot:
Add Schema class

https://gerrit.wikimedia.org/r/250057

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)).Nov 7 2015, 6:00 PM
phuedx moved this task from Code Review to Ready for Signoff on the Reading Web Sprint 59 - Amsterdam and the hamsters board.Nov 9 2015, 9:16 AM
phuedx closed this task as Resolved.Nov 9 2015, 9:18 AM

This task tracked a technical background-ish task. I'm signing this off in @Jdlrobson's absence.

phuedx moved this task from Ready for Signoff to Done on the Reading Web Sprint 59 - Amsterdam and the hamsters board.Nov 9 2015, 9:18 AM
Jdlrobson mentioned this in T167236: userSessionToken in RelatedArticles schema does not seem to survive beyond one pageview.Jun 14 2017, 3:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL