Page MenuHomePhabricator

Branch gets escaped twice when specified
Closed, ResolvedPublic


The branch name, when specified, is getting escaped in multiple places using wfEscapeShellArg(). The parameter should be escaped when it is being passed to a function for execution.

Event Timeline

Galorefitz claimed this task.
Galorefitz raised the priority of this task from to Needs Triage.
Galorefitz updated the task description. (Show Details)
Galorefitz added a subscriber: Galorefitz.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2015, 6:01 PM
Galorefitz renamed this task from Branch get's escaped twice when specified to Branch gets escaped twice when specified.Oct 30 2015, 6:35 PM
Galorefitz set Security to None.

Change 250061 had a related patch set uploaded (by Galorefitz):
Remove multiple wfEscapeShellArg() calls on $branch

Change 250061 merged by jenkins-bot:
Remove multiple wfEscapeShellArg() calls on $branch

Dereckson closed this task as Resolved.Nov 2 2015, 11:40 PM
Dereckson triaged this task as Normal priority.