Page MenuHomePhabricator
Create Task
Maniphest T117277

Extend 'requires' section of extension.json to include extensions
Closed, ResolvedPublic
Actions

Description

See this discussion on wikitech-l: https://lists.wikimedia.org/pipermail/wikitech-l/2015-October/083797.html

In short, extension.json has a 'requires' section where you can specify required MediaWiki core versions for an extension. It would be great if this section could be expanded to include 3rd party extensions, to handle cases where a 3rd party extension depends on another (for example, VikiSemanticTitle and VikiTitleIcon are plugins to the VIKI extension, and thus require VIKI to be installed).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
registration: Allow specifying extension dependenciesmediawiki/coremaster+197 -18
registration: Generalize CoreVersionChecker to VersionCheckermediawiki/coremaster+148 -87
registration: Don't let extensions load latemediawiki/coremaster+30 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jason.ji created this task.Oct 30 2015, 7:23 PM
Jason.ji raised the priority of this task from to Medium.
Jason.ji updated the task description. (Show Details)
Jason.ji subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2015, 7:23 PM
gerritbot subscribed.Oct 30 2015, 7:34 PM

Change 250060 had a related patch set uploaded (by Florianschmidtwelzow):
ExtensionRegistration: Implement Extension dependencies

https://gerrit.wikimedia.org/r/250060

gerritbot added a project: Patch-For-Review.Oct 30 2015, 7:34 PM
Florian claimed this task.Oct 30 2015, 7:36 PM
Florian added a project: MediaWiki-Configuration.
Florian added a subscriber: Legoktm.
Ricordisamoa subscribed.Oct 30 2015, 7:59 PM
Liuxinyu970226 set Security to None.Oct 31 2015, 1:29 AM
Glaisher subscribed.Oct 31 2015, 11:46 AM
Ltrlg subscribed.Nov 1 2015, 12:18 AM
• Spage subscribed.Nov 2 2015, 8:20 PM

This sounds like part of @Legoktm's T88596: Improving extension management RFC, proposal at https://www.mediawiki.org/wiki/Requests_for_comment/Improving_extension_management

Florian added a comment.Nov 2 2015, 10:35 PM

I agree, that this could be a part of this RfC (which sounds really great btw), but I would call it a very little one. The RfC goes far beyond: how to use extension.json's machine-readable format to provide a way for semi-automated extension/skin installations and upgrades, dependency management and correct downlpadable version in, e.g., ExtensionDistributor.

Having the possibility to name dependencies in extensions is, apart from that, a good idea and a step in the right direction, even of the RfC will not be implemented (which I don't hope), or if it takes very long to implement it. Also, we balready have MediaWiki core support in the require section :)

So I don't see this RfC as a blocker (I'm not sure, how you @Spage mean your comment, so sorry if I misunderstood you, and you don't think so, too :)).

Legoktm renamed this task from Extend 'requires' section of extension.json to include 3rd party extensions to Extend 'requires' section of extension.json to include extensions.Feb 27 2016, 12:46 AM
Legoktm added a parent task: T88596: Improving extension management.
Legoktm added a subscriber: Florian.
• RobLa-WMF subscribed.Mar 7 2016, 6:13 PM

Given that @Legoktm has identified this as a blocker for T88596, and given that this seems to be stalled, should we try adding this to the TechCom-RFC backlog? Turning this into an TechCom-RFC is technically as simple as adding the tag. Perhaps before doing that, summarizing the discussion on https://gerrit.wikimedia.org/r/250060 and capturing that in the description of this task that would be helpful. In particular, one can efficiently summarize the Gerrit review discussion by reading through the discussion and capturing the controversial, unanswered questions.

JanZerebecki mentioned this in T88596: Improving extension management.Mar 10 2016, 11:10 AM
J5lx subscribed.Jul 20 2016, 4:22 PM
Liuxinyu970226 subscribed.Jul 30 2016, 11:19 PM
SamanthaNguyen subscribed.Oct 17 2016, 4:06 AM
gerritbot added a comment.Nov 20 2016, 9:33 PM

Change 250060 had a related patch set uploaded (by Florianschmidtwelzow):
registration: Allow specifying extension dependencies

https://gerrit.wikimedia.org/r/250060

Legoktm mentioned this in T152263: Loading dependency from within another extension.Dec 3 2016, 3:16 AM
Legoktm added a parent task: T152263: Loading dependency from within another extension.
gerritbot added a comment.Dec 3 2016, 6:33 PM

Change 325117 had a related patch set uploaded (by Florianschmidtwelzow):
registration: Don't let extensions load lately

https://gerrit.wikimedia.org/r/325117

gerritbot added a comment.Dec 3 2016, 6:34 PM

Change 325118 had a related patch set uploaded (by Florianschmidtwelzow):
registration: Generalize CoreVersionChecker to VersionChecker

https://gerrit.wikimedia.org/r/325118

Paladox subscribed.Dec 3 2016, 8:27 PM
gerritbot added a comment.Dec 6 2016, 6:09 PM

Change 325117 merged by jenkins-bot:
registration: Don't let extensions load late

https://gerrit.wikimedia.org/r/325117

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 6 2016, 7:00 PM
Jdforrester-WMF awarded a token.Dec 16 2016, 12:53 AM
gerritbot added a comment.Dec 16 2016, 12:58 AM

Change 325118 merged by jenkins-bot:
registration: Generalize CoreVersionChecker to VersionChecker

https://gerrit.wikimedia.org/r/325118

gerritbot added a comment.Dec 16 2016, 1:00 AM

Change 250060 merged by jenkins-bot:
registration: Allow specifying extension dependencies

https://gerrit.wikimedia.org/r/250060

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 16 2016, 1:00 AM
Jdforrester-WMF closed this task as Resolved.Dec 16 2016, 4:30 AM
Jdforrester-WMF subscribed.

\o/

Florian added a comment.Dec 16 2016, 12:10 PM

*yay*

cicalese subscribed.Dec 16 2016, 1:31 PM

Awesome!

Liuxinyu970226 unsubscribed.Dec 16 2016, 2:50 PM
Legoktm mentioned this in T32234: Allow definition of Extension Dependencies.Sep 28 2017, 1:08 AM
hashar mentioned this in T182336: mediawiki/core tests failing for REL1_30 due to Wikibase.Dec 7 2017, 8:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits