Page MenuHomePhabricator

Default skin set to vector, even though no skins installed prior to running installer
Open, LowPublic

Description

## Default skin: you can change the default skin. Use the internal symbolic
## names, ie 'vector', 'monobook':
$wgDefaultSkin = "vector";

Why is $wgDefaultSkin set? Maybe set and commented would be useful...

Event Timeline

Reedy raised the priority of this task from to Needs Triage.
Reedy updated the task description. (Show Details)
Reedy added a project: MediaWiki-Installer.
Reedy subscribed.
Reedy set Security to None.

Change 584069 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] WIP: WebInstaller uses fallback skin by default but can be skinned

https://gerrit.wikimedia.org/r/584069

Change 581774 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MonoBook@master] POC: Monobook installer

https://gerrit.wikimedia.org/r/581774

Change 584081 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] POC: Use getSkinTemplateData and support installer

https://gerrit.wikimedia.org/r/584081

I can see a way of doing this provided we embrace Mustache templates. My POC shows how it would work for Monobook, Vector and Minerva.
The only issue with the POC is the buffering - @Reedy I wonder if you know the installer well enough to provide ideas there?

The only real blocker for making it possible for skins to skin the installer would be T248752.
Ideally we'd add a step to the beginning of the installer offering the available skins to run the installer in.

It's a 5 year old bug... I think my point was something about it being set to vector (and active/not commented), even if the skin wasn't installed

Which still seems to be the case

## Default skin: you can change the default skin. Use the internal symbolic
## names, ie 'vector', 'monobook':
\$wgDefaultSkin = \"{$this->values['wgDefaultSkin']}\";

Though, considering we set similar in DefaultSettings anyway...

/**
 * Default skin, for new users and anonymous visitors. Registered users may
 * change this to any one of the other available skins in their preferences.
 */
$wgDefaultSkin = 'vector';

/**
 * Fallback skin used when the skin defined by $wgDefaultSkin can't be found.
 *
 * @since 1.24
 */
$wgFallbackSkin = 'fallback';
``

My bad. Misread the ticket. Will remove the associations :)

Change 584081 abandoned by Jdlrobson:
POC: Use getSkinTemplateData and support installer

Reason:
Per https://gerrit.wikimedia.org/r/581771 I'm likely being too ambitious at this time. I'll look to make smaller more focused changes that move in this direction.

https://gerrit.wikimedia.org/r/584081

Change 581774 abandoned by Jdlrobson:
POC: Monobook installer

Reason:
Per https://gerrit.wikimedia.org/r/581771 I'm likely being too ambitious at this time. I'll look to make smaller more focused changes that move in this direction.

https://gerrit.wikimedia.org/r/581774

Change 584069 abandoned by Jdlrobson:
WIP: WebInstaller uses fallback skin by default but can be skinned

Reason:
Per https://gerrit.wikimedia.org/r/581771 I'm likely being too ambitious at this time. I'll look to make smaller more focused changes that move in this direction.

https://gerrit.wikimedia.org/r/584069