Page MenuHomePhabricator
Create Task
Maniphest T117347

UrlShortener does not normalize percent encoding
Closed, ResolvedPublic
Actions

Description

https://en.wikipedia.org/wiki/Scott_Morrison_%28politician%29 and https://en.wikipedia.org/wiki/Scott_Morrison_(politician) are being treated as two different URLs.

Realized this during discussion on T116986.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
urldecode() provided input before storing itmediawiki/extensions/UrlShortenermaster+8 -0
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Nov 1 2015, 3:32 AM
Legoktm raised the priority of this task from to High.
Legoktm updated the task description. (Show Details)
Legoktm added a project: MediaWiki-extensions-UrlShortener.
Legoktm added subscribers: Legoktm, yuvipanda.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2015, 3:32 AM
gerritbot subscribed.Nov 1 2015, 6:14 AM

Change 250299 had a related patch set uploaded (by Legoktm):
urldecode() provided input before storing it

https://gerrit.wikimedia.org/r/250299

gerritbot added a project: Patch-For-Review.Nov 1 2015, 6:14 AM
gerritbot added a comment.Jun 3 2016, 1:32 AM

Change 250299 merged by jenkins-bot:
urldecode() provided input before storing it

https://gerrit.wikimedia.org/r/250299

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)).Jun 8 2016, 3:01 PM
yuvipanda unsubscribed.Jun 30 2016, 2:06 PM
Legoktm closed this task as Resolved.Jul 7 2016, 8:54 AM
Legoktm claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits