Deliver page content language together with the extract
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Fomafix
	Nov 2 2015, 8:37 AM

Description

The language code of the page content language and the direction of the language is needed to generate the HTML attributes lang and dir. The lang must be BCP 47 conform. The mapping from the internal language code to the BCP 47 conform language code and the mapping from the language code to the direction of the language exists only in PHP, so they have to delivered with the response.

I see two possibilities:

"extract": "<p>Eine <b>Strasse</b> (von lat. [via] <i>strata</i> «gepflasterter Weg») ist ein …</p>",
"lang": "de-CH",
"dir": "ltr",

"extract": "<div class=\"mw-content-ltr\" dir=\"ltr\" lang=\"de-CH\"><p>Eine <b>Strasse</b> (von lat. [via] <i>strata</i> «gepflasterter Weg») ist ein …</p></div>",

I prefer the second option but this is an incompatible change.

Details

	Subject	Repo	Branch	Lines +/-
	API: Add the code and the direction of the page content language	mediawiki/extensions/TextExtracts	master	+3 -0
	ApiQueryInfo.php: Add code and direction of the page content language	mediawiki/core	master	+5 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Dereckson	T68374 Enable Hovercards on se.wikimedia.org (Swedish chapter wiki)
Resolved	Jdlrobson	T70860 [GOAL] Graduate Page Previews feature (Popups extension) out of Beta Feature
Resolved	• Gilles	T70861 Performance review #2 of Hovercards (Popups extension)
Resolved	phuedx	T149801 [EPIC] Refactor Hovercards (née Popups)
Resolved	ovasileva	T156290 Merge mpga branch into master
Resolved	ovasileva	T123445 Add support for RESTBase endpoint consumption
Resolved	Fomafix	T68114 Hovercards: Add `lang` and `dir` attributes to the `.mwe-popups-extract`
Resolved	Fomafix	T117392 Deliver page content language together with the extract

Event Timeline

Fomafix created this task.Nov 2 2015, 8:37 AM

Fomafix raised the priority of this task from to Needs Triage.

Fomafix updated the task description. (Show Details)

Fomafix added a project: TextExtracts.

Fomafix added a subscriber: Fomafix.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2015, 8:37 AM

Fomafix added a parent task: T68114: Hovercards: Add `lang` and `dir` attributes to the `.mwe-popups-extract`.Nov 2 2015, 8:39 AM

Fomafix triaged this task as Medium priority.Nov 2 2015, 8:44 AM

Fomafix updated the task description. (Show Details)

Fomafix set Security to None.

Fomafix updated the task description. (Show Details)Nov 2 2015, 9:03 AM

Fomafix updated the task description. (Show Details)Nov 2 2015, 10:19 AM

Fomafix updated the task description. (Show Details)Nov 2 2015, 1:49 PM

Fomafix claimed this task.Nov 2 2015, 5:13 PM

Change 250456 had a related patch set uploaded (by Gerrit Patch Uploader):
API: Enclose extract in an element with page content language attributes

https://gerrit.wikimedia.org/r/250456

gerritbot added a project: Patch-For-Review.Nov 2 2015, 5:18 PM

Adding prop=info already delivers

"pagelanguage": "de-ch"

But this language code has to wfBCP47()fied and the mapping to the direction of the language is missing in JavaScript.

actually lang->getHtmlCode() is already BCP47'ified:

public function getHtmlCode() {
                if ( is_null( $this->mHtmlCode ) ) {
                        $this->mHtmlCode = wfBCP47( $this->getCode() );
}

I think the first solution you propose is actually a better one - the caller should take care of the rendering/wrapping.

I agree with jon that it the first solution is better. It matches what we do in other areas of the api.

Change 250760 had a related patch set uploaded (by Gerrit Patch Uploader):
ApiQueryInfo.php: Add code and direction of the page content language

https://gerrit.wikimedia.org/r/250760

Change 250760 merged by jenkins-bot:
ApiQueryInfo.php: Add code and direction of the page content language

https://gerrit.wikimedia.org/r/250760

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)).Nov 4 2015, 10:00 PM

pagelanguagehtmlcode and pagelanguagedir are now available! yay!

Fomafix removed a project: Patch-For-Review.Nov 6 2015, 7:53 PM

• Prtksxna added a subscriber: • Prtksxna.Nov 16 2015, 6:08 AM

Change 250456 abandoned by Fomafix:
API: Add the code and the direction of the page content language

Reason:
Superseded by https://gerrit.wikimedia.org/r/250760