Page MenuHomePhabricator

Spike: CentralNotice: Verify that our Special:HideBanners cookie storm works as efficiently as possible
Closed, ResolvedPublic2 Estimated Story PointsSpike

Description

To hide banners across domains after a user clicks on a banner's close button, we call Special:HideBanners a lot... As long as this mechanism persists (see T117433 for an investigation of alternatives) it's important that we ensure it works as efficiently as possible. Double-check the Varnish configuration, HTTP headers, PHP and JS code, and anything else that could be tuned to reduce the load all around.

Event Timeline

AndyRussG raised the priority of this task from to Needs Triage.
AndyRussG updated the task description. (Show Details)
AndyRussG moved this task to Triage on the Fundraising-Backlog board.
AndyRussG added subscribers: AndyRussG, Nuria.
AndyRussG edited a custom field.

Here are the cache headers we set from the special page:

Cache-Control: public, s-maxage=86400, max-age=0

We arrived at that in a pretty amateur way, and it looks a bit funny in hindsight, so review would be appreciated. The idea is that the response is cacheable by our Varnishes or any intermediate proxy. I don't know why we're preventing client-side caching with max-age=0, but I don't think there's much of a use case for caching on the client though, cos it's rare that any individual will be hitting the same category of close box more than once per year.

chasemp triaged this task as Medium priority.May 5 2016, 8:44 PM
BBlack claimed this task.
BBlack subscribed.

Resolving for now, no movement since last update in 2015. Make a new modern ticket if there's still issues here!

Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptSep 23 2020, 5:27 PM