Page MenuHomePhabricator

DCAT-AP: Issued and modified should be typed
Closed, ResolvedPublic

Description

Broken out from T103087#1773596

According to the DCAT-AP specifications (latest) the properties issued and modified should be "rdfs:Literal typed as xsd:date or xsd:dateTime".

Details

Related Changes in Gerrit:

Event Timeline

Lokal_Profil claimed this task.
Lokal_Profil raised the priority of this task from to Needs Triage.
Lokal_Profil updated the task description. (Show Details)

OK. So what needs to be done is adding rdf:datatype="http://www.w3.org/2001/XMLSchema#date" to all of the issued, modified tags?

Change 251492 had a related patch set uploaded (by Lokal Profil):
Make issued and modified typed

https://gerrit.wikimedia.org/r/251492

To be clear I actually believe this is only needed to be compliant with v. 1.1. The version we have been working with is 1.0 so there might be more differences which should be implemented for full compliance with 1.1.

That said I don't think it is a problem introducing it (the patch) already now.

But it isn't there in 1.00 https://joinup.ec.europa.eu/system/files/project/dcat-ap_final_v1.00_0.html#Data%20Catalogue%20-%20release%20date

There is however not a nice table (like in 0.06 and 1.01) so it might have been intended but never made it in.

I don't see on the website the version 1.00 as PDF and I do agree with you it is not there. I think that html table is not fully descriptive compared to the PDF we should ask to the authors the version 1.00

@hoo, @ArielGlenn:
Could either of you do the code review for the patch (or ping in someone else)? It and the subsequent i18n update should both be fairly trivial but have been waiting about a month.

Change 251492 abandoned by Lokal Profil:
Make issued and modified typed

Reason:
Code is live in operations/dumps/dcat and was reviewed per https://gerrit.wikimedia.org/r/#/c/260247/

https://gerrit.wikimedia.org/r/251492

Code deployed in operations/dumps/dcat which should fix the issue next time it is run.

Code deployed in operations/dumps/dcat which should fix the issue next time it is run.

The new code has not yet been deployed (as the puppet patch making use of the new repo hasn't been merged). I hope that this will happen this week, but can't promise it.

Code deployed in operations/dumps/dcat which should fix the issue next time it is run.

The new code has not yet been deployed (as the puppet patch making use of the new repo hasn't been merged). I hope that this will happen this week, but can't promise it.

No worries. I wrote this when I saw that the patches had been merged into the new repo but before I spotted the puppet file at the end of the other patch.

The new code has been deployed now and I have regenerated the file. Looks good to me.