Page MenuHomePhabricator

[Regression wmf.5] Getting "Switch to Visual Editing?" dialog after saving a page and trying to re-open VE
Closed, ResolvedPublic1 Estimated Story Points

Description

  1. Edit a page
  2. Save the edit

3.Try to reopen the VE

Observe that, "Switch to Visual Editing?" dialog appears asking do I want to discard or save the edit, which I already saved

Event Timeline

Ryasmeen created this task.Nov 3 2015, 8:05 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen added a subscriber: Ryasmeen.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 3 2015, 8:05 PM
Ryasmeen renamed this task from Getting "Switch to Visual Editing?" dialog after saving a page and trying to re-open VE to [Regression pre-wmf.5]Getting "Switch to Visual Editing?" dialog after saving a page and trying to re-open VE.Nov 3 2015, 8:06 PM
Ryasmeen updated the task description. (Show Details)
Ryasmeen set Security to None.
Jdforrester-WMF triaged this task as High priority.Nov 3 2015, 8:15 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added a subscriber: Krenair.

Change 250765 had a related patch set uploaded (by Alex Monk):
Fix check for loading from modified action=edit

https://gerrit.wikimedia.org/r/250765

Change 250872 had a related patch set uploaded (by Jforrester):
Fix check for loading from modified action=edit

https://gerrit.wikimedia.org/r/250872

Change 250765 merged by jenkins-bot:
Fix check for loading from modified action=edit

https://gerrit.wikimedia.org/r/250765

Change 250872 merged by Alex Monk:
Fix check for loading from modified action=edit

https://gerrit.wikimedia.org/r/250872

Jdforrester-WMF renamed this task from [Regression pre-wmf.5]Getting "Switch to Visual Editing?" dialog after saving a page and trying to re-open VE to [Regression wmf.5] Getting "Switch to Visual Editing?" dialog after saving a page and trying to re-open VE.Nov 4 2015, 12:47 AM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF assigned this task to Krenair.
Ryasmeen reopened this task as Open.Nov 4 2015, 1:05 AM
Krenair closed this task as Resolved.Nov 4 2015, 1:12 AM

James found a more complicated version of this bug that still exists. If you switch from WT to VE, save, then try to load VE, it shows the popup. Probably need to change the mw.config.get( 'wgAction' ) calls to mw.util.getParamValue( 'action' )

We should also consider updating wgAction when we mess with them in the URL.

Krenair reopened this task as Open.Nov 4 2015, 1:47 AM

Change 250892 had a related patch set uploaded (by Alex Monk):
Set wgAction when messing with the action URL parameter

https://gerrit.wikimedia.org/r/250892

Change 250892 merged by jenkins-bot:
Set wgAction when messing with the action URL parameter

https://gerrit.wikimedia.org/r/250892

Change 250963 had a related patch set uploaded (by Jforrester):
Set wgAction when messing with the action URL parameter

https://gerrit.wikimedia.org/r/250963

Jdforrester-WMF closed this task as Resolved.Nov 4 2015, 2:42 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Now it's fixed in master; going to wmf.5 in an hour.

Change 250963 merged by Jforrester:
Set wgAction when messing with the action URL parameter

https://gerrit.wikimedia.org/r/250963