Page MenuHomePhabricator
Create Task
Maniphest T117650

CentralNotice: use KVStore instead of cookies for mixins that create cookies, except for Fundraising
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Sine we moved commonly used in-banner JS into campaign-associated mixins, we are allowing CentralNotice admins to create new cookies quite easily. This could lead to a proliferation of campaign-specific cookies with year-long expiries. To prevent this, use KVStore (LocalStorage) for non-Fundraising campaigns. For now, because of the upcoming year-end campaigns, we'll keep Fundraising on the proven and broadly compatible cookie system.

Details

SubjectRepoBranchLines +/-
largeBannerLimit: Use KV store instead of cookies for campaign categories not using legacymediawiki/extensions/CentralNoticemaster+91 -27
impressionDiet: fix and minor improvements in use KV store featuremediawiki/extensions/CentralNoticemaster+52 -47
impressionDiet: Use KV store instead of cookies for campaign categories using legacymediawiki/extensions/CentralNoticemaster+221 -83
Make cookiesEnabled() a public mw.centralNotice functionmediawiki/extensions/CentralNoticemaster+17 -11
Campaign categories using legacy: global config var and data propertymediawiki/extensions/CentralNoticemaster+18 -1
KVStore: Allow custom TTL for itemsmediawiki/extensions/CentralNoticemaster+5 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

• AndyRussG created this task.Nov 4 2015, 2:24 AM
• AndyRussG claimed this task.
• AndyRussG raised the priority of this task from to Needs Triage.
• AndyRussG updated the task description. (Show Details)
• AndyRussG added projects: Fundraising Sprint William Shatner, MediaWiki-extensions-CentralNotice, Fundraising-Backlog, Performance Issue.
• AndyRussG moved this task to Backlog on the Fundraising Sprint William Shatner board.
• AndyRussG added a subscriber: • AndyRussG.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 4 2015, 2:24 AM
• AndyRussG set Security to None.Nov 4 2015, 2:25 AM
• AndyRussG edited a custom field.
• AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint William Shatner board.
• atgo added a project: Unplanned-Sprint-Work.Nov 4 2015, 6:38 PM
• atgo added a subscriber: • atgo.
gerritbot added a subscriber: gerritbot.Nov 4 2015, 7:26 PM

Change 251026 had a related patch set uploaded (by AndyRussG):
KVStore: Allow custom TTL for items

https://gerrit.wikimedia.org/r/251026

gerritbot added a project: Patch-For-Review.Nov 4 2015, 7:26 PM
gerritbot added a comment.Nov 5 2015, 5:29 PM

Change 251284 had a related patch set uploaded (by AndyRussG):
Campaign categories using legacy: global config var and data property

https://gerrit.wikimedia.org/r/251284

gerritbot added a comment.Nov 5 2015, 7:42 PM

Change 251026 merged by Ejegg:
KVStore: Allow custom TTL for items

https://gerrit.wikimedia.org/r/251026

gerritbot added a comment.Nov 5 2015, 10:01 PM

Change 251419 had a related patch set uploaded (by AndyRussG):
Make cookiesEnabled() a public mw.centralNotice function

https://gerrit.wikimedia.org/r/251419

gerritbot added a comment.Nov 6 2015, 5:46 AM

Change 251462 had a related patch set uploaded (by AndyRussG):
impressionDiet: Use KV store instead of cookies for campaign categories using legacy

https://gerrit.wikimedia.org/r/251462

gerritbot added a comment.Nov 6 2015, 7:39 PM

Change 251284 merged by Ejegg:
Campaign categories using legacy: global config var and data property

https://gerrit.wikimedia.org/r/251284

gerritbot added a comment.Nov 6 2015, 7:42 PM

Change 251419 merged by Ejegg:
Make cookiesEnabled() a public mw.centralNotice function

https://gerrit.wikimedia.org/r/251419

gerritbot added a comment.Nov 6 2015, 10:55 PM

Change 251462 merged by jenkins-bot:
impressionDiet: Use KV store instead of cookies for campaign categories using legacy

https://gerrit.wikimedia.org/r/251462

gerritbot added a comment.Nov 7 2015, 3:12 PM

Change 251708 had a related patch set uploaded (by AndyRussG):
impressionDiet: fix and minor improvements in use KV store feature

https://gerrit.wikimedia.org/r/251708

gerritbot added a comment.Nov 7 2015, 3:40 PM

Change 251711 had a related patch set uploaded (by AndyRussG):
largeBannerLimit: Use KV store instead of cookies for campaign categories using legacy

https://gerrit.wikimedia.org/r/251711

• AndyRussG moved this task from Doing to Review on the Fundraising Sprint William Shatner board.Nov 7 2015, 3:56 PM
gerritbot added a comment.Nov 9 2015, 7:46 PM

Change 251708 merged by jenkins-bot:
impressionDiet: fix and minor improvements in use KV store feature

https://gerrit.wikimedia.org/r/251708

gerritbot added a comment.Nov 9 2015, 10:42 PM

Change 251711 merged by jenkins-bot:
largeBannerLimit: Use KV store instead of cookies for campaign categories not using legacy

https://gerrit.wikimedia.org/r/251711

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint William Shatner board.Nov 10 2015, 6:04 AM
• atgo moved this task from Triage to Closed Sprint Work Completed in Q2 1516 on the Fundraising-Backlog board.Nov 10 2015, 6:07 PM
• DStrine added a project: Fundraising Sprint X-Ray Spex.Nov 10 2015, 6:08 PM
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint X-Ray Spex board.Nov 10 2015, 6:26 PM
• AndyRussG closed this task as Resolved.Nov 13 2015, 3:38 AM
• AndyRussG moved this task from Pending Deployment to Done on the Fundraising Sprint X-Ray Spex board.
• DStrine removed a project: Unplanned-Sprint-Work.Nov 17 2015, 12:19 AM
Nemo_bis added a parent task: T108849: Move CentralNotice stuff out of cookies.Nov 19 2015, 8:49 AM
• atgo removed a subscriber: • atgo.Mar 30 2016, 10:03 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL