Page MenuHomePhabricator

CentralNotice: use KVStore instead of cookies for mixins that create cookies, except for Fundraising
Closed, ResolvedPublic2 Estimated Story Points

Description

Sine we moved commonly used in-banner JS into campaign-associated mixins, we are allowing CentralNotice admins to create new cookies quite easily. This could lead to a proliferation of campaign-specific cookies with year-long expiries. To prevent this, use KVStore (LocalStorage) for non-Fundraising campaigns. For now, because of the upcoming year-end campaigns, we'll keep Fundraising on the proven and broadly compatible cookie system.

Event Timeline

AndyRussG created this task.Nov 4 2015, 2:24 AM
AndyRussG claimed this task.
AndyRussG raised the priority of this task from to Needs Triage.
AndyRussG updated the task description. (Show Details)
AndyRussG moved this task to Backlog on the Fundraising Sprint William Shatner board.
AndyRussG added a subscriber: AndyRussG.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 4 2015, 2:24 AM
AndyRussG set Security to None.Nov 4 2015, 2:25 AM
AndyRussG edited a custom field.
AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint William Shatner board.

Change 251026 had a related patch set uploaded (by AndyRussG):
KVStore: Allow custom TTL for items

https://gerrit.wikimedia.org/r/251026

Change 251284 had a related patch set uploaded (by AndyRussG):
Campaign categories using legacy: global config var and data property

https://gerrit.wikimedia.org/r/251284

Change 251026 merged by Ejegg:
KVStore: Allow custom TTL for items

https://gerrit.wikimedia.org/r/251026

Change 251419 had a related patch set uploaded (by AndyRussG):
Make cookiesEnabled() a public mw.centralNotice function

https://gerrit.wikimedia.org/r/251419

Change 251462 had a related patch set uploaded (by AndyRussG):
impressionDiet: Use KV store instead of cookies for campaign categories using legacy

https://gerrit.wikimedia.org/r/251462

Change 251284 merged by Ejegg:
Campaign categories using legacy: global config var and data property

https://gerrit.wikimedia.org/r/251284

Change 251419 merged by Ejegg:
Make cookiesEnabled() a public mw.centralNotice function

https://gerrit.wikimedia.org/r/251419

Change 251462 merged by jenkins-bot:
impressionDiet: Use KV store instead of cookies for campaign categories using legacy

https://gerrit.wikimedia.org/r/251462

Change 251708 had a related patch set uploaded (by AndyRussG):
impressionDiet: fix and minor improvements in use KV store feature

https://gerrit.wikimedia.org/r/251708

Change 251711 had a related patch set uploaded (by AndyRussG):
largeBannerLimit: Use KV store instead of cookies for campaign categories using legacy

https://gerrit.wikimedia.org/r/251711

Change 251708 merged by jenkins-bot:
impressionDiet: fix and minor improvements in use KV store feature

https://gerrit.wikimedia.org/r/251708

Change 251711 merged by jenkins-bot:
largeBannerLimit: Use KV store instead of cookies for campaign categories not using legacy

https://gerrit.wikimedia.org/r/251711

AndyRussG closed this task as Resolved.Nov 13 2015, 3:38 AM
AndyRussG moved this task from Pending Deployment to Done on the Fundraising Sprint X-Ray Spex board.