Page MenuHomePhabricator
Create Task
Maniphest T117674

[Task] ESC key should close property suggester dropdown and statement edit mode
Closed, ResolvedPublic
Actions

Description

Currently there is a race conditions in the UI for editing an item value in a statement: After typing but before the PropertySuggester shows its item suggestions or if the property suggester is not deployed, ESC cancels the edit. If the PropertySuggester shows, ESC only closes the property suggester. So the current behavior is different depending on latency.

One solution is to pass on the ESC from the PropertySuggester to cancel the edit. (Result is that there is no keyboard shortcut to only cancel the PropertySuggester anymore.)

Another solution would be to show the suggester at the same time as showing the edit field and still needing one ESC for closing the pop up and one for canceling the edit.

The PropertySuggester should behave the same way as the EntitySuggester and other popups.

This is also causing failures in the browsertests, since they don't check whether the property suggester is deployed or not.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix: Property suggester leads to test failwikidata/browsertestsmaster+7 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tobi_WMDE_SW created this task.Nov 4 2015, 11:13 AM
Tobi_WMDE_SW raised the priority of this task from to Medium.
Tobi_WMDE_SW updated the task description. (Show Details)
Tobi_WMDE_SW added projects: Wikidata, Wikidata-Sprint-2015-11-03.
Tobi_WMDE_SW added subscribers: Tobi_WMDE_SW, JanZerebecki, • adrianheine.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2015, 11:13 AM
JanZerebecki added a parent task: T92619: make Wikidata browsertests non-flaky (tracking).Nov 4 2015, 11:14 AM
Lydia_Pintscher subscribed.Nov 8 2015, 5:17 PM

Please be more specific in writing these tasks.
Is this about a behavior change of the existing UI? Is this about testing something as the blocker seems to indicate?

JanZerebecki added a comment.Nov 8 2015, 5:47 PM

This is about changing the exiting UI. Currently there is a race conditions in the UI for editing an item value in a statement. After typing but before the PropertySuggester shows its item suggestions, ESC cancels the edit. If the PropertySuggester shows, ESC only closes the property suggester. The current behavior is different depending on latency. Making the UI more predictable has the nice effect of allowing us to easily make a non-flaky browser test.

Lydia_Pintscher added a comment.Nov 8 2015, 6:29 PM

Ok thanks. This really isn't clear from the initial description.

Tobi_WMDE_SW updated the task description. (Show Details)Nov 9 2015, 11:05 AM
Tobi_WMDE_SW set Security to None.

@Lydia_Pintscher I've updated the task description according to @JanZerebecki's comment.

Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-11-17.Nov 16 2015, 2:40 PM
JanZerebecki updated the task description. (Show Details)Apr 30 2016, 10:20 PM
JanZerebecki added a project: Wikidata-Sprint-2016-05-10.May 10 2016, 6:31 PM
JanZerebecki moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-05-10 board.
Tobi_WMDE_SW assigned this task to • Jonas.May 11 2016, 9:52 AM
Tobi_WMDE_SW moved this task from Backlog to Doing on the Wikidata-Sprint-2016-05-10 board.
JanZerebecki added a comment.May 11 2016, 12:59 PM

See also
https://integration.wikimedia.org/ci/view/BrowserTests/view/-Dashboard/job/browsertests-Wikidata-WikidataTests-linux-firefox-sauce/lastBuild/testReport/%28root%29/Creating%20statements/Cancel_statement__outline_example_____press_the_ESC_key_in_the_claim_entity_selector_input_field___/
7a23ebd2356ab71b505e67bcb45672afc04b79c1

JanZerebecki updated the task description. (Show Details)May 11 2016, 1:19 PM
gerritbot subscribed.May 11 2016, 3:19 PM

Change 288209 had a related patch set uploaded (by Jonas Kress (WMDE)):
Fix: Property suggester leads to test fail

https://gerrit.wikimedia.org/r/288209

gerritbot added a project: Patch-For-Review.May 11 2016, 3:19 PM
• Jonas mentioned this in R1909:5937c7aa8696: Fix: Property suggester leads to test fail.May 11 2016, 3:19 PM
gerritbot added a comment.May 11 2016, 3:25 PM

Change 288209 merged by jenkins-bot:
Fix: Property suggester leads to test fail

https://gerrit.wikimedia.org/r/288209

• Jonas added a comment.May 11 2016, 3:26 PM

Browsertests are failing, because when property suggester is present entity selector opens directly when entering edit mode.
There is no race condition whatsoever...

• Jonas moved this task from Doing to Review on the Wikidata-Sprint-2016-05-10 board.May 11 2016, 3:26 PM
• Jonas closed this task as Resolved.May 11 2016, 3:29 PM
JanZerebecki mentioned this in T135009: ESC key should only cancel editing instead of first only closing an pop up (suggester or expert).May 11 2016, 4:28 PM
JanZerebecki reopened this task as Open.May 11 2016, 4:35 PM
JanZerebecki moved this task from Proposed to Doing on the Wikidata-Sprint-2015-11-03 board.

R1909:5937c7aa8696a1711f7d22d51da07e32186adf2b#1810119

JanZerebecki moved this task from Doing to Proposed on the Wikidata-Sprint-2015-11-03 board.May 11 2016, 4:35 PM
JanZerebecki moved this task from Review to Doing on the Wikidata-Sprint-2016-05-10 board.
gerritbot added a comment.May 12 2016, 1:47 PM

Change 288391 had a related patch set uploaded (by Jonas Kress (WMDE)):
Introduce step "I Close the entity selector if present"

https://gerrit.wikimedia.org/r/288391

• Jonas mentioned this in R1909:256f6a2e08b4: Introduce step "I Close the entity selector if present".May 12 2016, 1:47 PM
thiemowmde closed this task as Resolved.May 12 2016, 2:10 PM
thiemowmde moved this task from Doing to Done on the Wikidata-Sprint-2016-05-10 board.
• Jan_Dittrich subscribed.May 12 2016, 3:42 PM

Thiemo asked me about my UX view on that issue. In general, the single-escape = out (Thiemos suggestion) makes sense, but I can not judge how much people may rely on that and got used to it.

• Jan_Dittrich added a comment.May 18 2016, 4:04 PM

If we deem this as important (or just interesting) we could make this part of a small, informal usability test – we could ask in-house, since I assume not everyone is familiar with data entry behavior in wikidata.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits