Looks pretty easy.
| Before | After |
|---|---|
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Changed OOUI | mediawiki/core | master | +4 -4 | |
| Convert Special:BookSources to use OOUI | mediawiki/core | master | +34 -37 | |
| Changed SpecialBookSources.php to OOUI | mediawiki/core | master | +20 -42 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core | |||
| Open | None | T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core | |||
| Open | None | T100161 Convert all of MediaWiki core to OOUI PHP (tracking) | |||
| Open | None | T107037 Convert all MW core special pages to OOUI | |||
| Resolved | Sethakill | T117747 Convert Special:BookSources to OOUI |
Event Timeline
Comment Actions
https://gerrit.wikimedia.org/r/236270 converts SpecialBookSources from SpecialPage to FormSpecialPage.
Then, it is only a matter of changing getDisplayFormat().
Comment Actions
Change 286594 had a related patch set uploaded (by Sethakill):
Convert Special:BookSources to use OOUI
Comment Actions
Change 277050 abandoned by Jforrester:
Changed OOUI
Reason:
Parent abandoned by same author.
Comment Actions
Why is there an indicator ?
And shouldn't we make it a rule that if a button submits only a single textfield, the controls should be on the same line in wide ui's ? Seems a bit of a waste of the vertical space.
Comment Actions
On my 13" screen it's almost a third of the vertical space:
It seems considerably less efficient.
[edit] Don't mind the width, that's my own personal styling (and so is the yellow for focus)
Comment Actions
@TheDJ I don't agree that horizontal layout of button aside of input gives any advantage here, on contrary I think, that from eye movement the vertical layout makes this specific form even easier to use.
I've already started at T136790: Improve form layouts in OOUI MW core forms for better user experience to collect some general points to work on OOjs UI form layouts. Please help identify and add overall issues there.
Comment Actions
Further comments about this OOUI change, at https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=724187004#Special:BookSources
Excerpts:
Why is the box at Special:BookSources spread over four lines instead of two, why does it have fuzzy edges? Both of these waste space, and mean that extra scrolling is now necessary where it wasn't before. It looks very much like it's Vector skin, although I use MonoBook. And what's the asterisk for?
I'm not a fan of the large space use in mw:OOUI. [...] I use Special:ExpandTemplates a lot and also find OOUI annoying there.
I'll personally add, for Special:Booksources in particular: The input field should only be 17 characters long.
- ISBNs can only be 17 characters long (13+4 separators). We could forcibly restrict it to that many characters, but we probably want to give users room to edit (by adding and then subtracting characters) or to paste longer clipboard text and then reduce it down.