Page MenuHomePhabricator

OOUIHTMLForm wraps Hidden fields into a fieldset
Closed, ResolvedPublic

Description

Take a look at this implementation:
https://github.com/wikimedia/mediawiki/blob/master/includes/specials/SpecialComparePages.php#L89-L100

Switching it to OOUI should generate an output like:

but instead creates empty elements for the hidden fields:


(see the three elements, one is marked)

Event Timeline

Florian created this task.Nov 4 2015, 6:29 PM
Florian raised the priority of this task from to Medium.
Florian updated the task description. (Show Details)
Florian updated the task description. (Show Details)
Florian set Security to None.
Florian added subscribers: gerritbot, Florian, Paladox and 5 others.
Florian claimed this task.Nov 4 2015, 6:38 PM

Change 251018 had a related patch set uploaded (by Florianschmidtwelzow):
HTMLForm: Do not render hidden elements as elements

https://gerrit.wikimedia.org/r/251018

matmarex closed this task as Resolved.Nov 19 2015, 4:18 PM
matmarex removed a project: Patch-For-Review.

Change 251018 merged by jenkins-bot:
HTMLForm: Do not render hidden elements as elements

https://gerrit.wikimedia.org/r/251018