Maniphest T117768

OOUIHTMLForm wraps Hidden fields into a fieldset
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Florian
	Nov 4 2015, 6:29 PM

Tags

Referenced Files

	F2914649: not_desired.PNG
	Nov 4 2015, 6:29 PM

	F2914646: desired.PNG
	Nov 4 2015, 6:29 PM

Subscribers

Jdforrester-WMF

Description

Take a look at this implementation:
https://github.com/wikimedia/mediawiki/blob/master/includes/specials/SpecialComparePages.php#L89-L100

Switching it to OOUI should generate an output like:

desired.PNG (824×1 px, 112 KB)

but instead creates empty elements for the hidden fields:

not_desired.PNG (864×1 px, 134 KB)

(see the three elements, one is marked)

Details

	Subject	Repo	Branch	Lines +/-
	HTMLForm: Do not render hidden elements as elements	mediawiki/core	master	+28 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
		Open		None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
		Open		None	T100161 Convert all of MediaWiki core to OOUI PHP (tracking)
		Open		None	T107037 Convert all MW core special pages to OOUI
		Resolved		Florian	T117752 Convert Special:ComparePages to OOUI
		Resolved		Florian	T117768 OOUIHTMLForm wraps Hidden fields into a fieldset

Event Timeline

Florian created this task.Nov 4 2015, 6:29 PM

Florian raised the priority of this task from to Medium.

Florian updated the task description. (Show Details)

Florian added projects: UI-Standardization, MediaWiki-HTMLForm.

Florian updated the task description. (Show Details)

Florian set Security to None.

Florian added subscribers: gerritbot, Florian, Paladox and 5 others.

Florian claimed this task.Nov 4 2015, 6:38 PM

Change 251018 had a related patch set uploaded (by Florianschmidtwelzow):
HTMLForm: Do not render hidden elements as elements

https://gerrit.wikimedia.org/r/251018

gerritbot added a project: Patch-For-Review.Nov 4 2015, 6:43 PM

matmarex closed this task as Resolved.Nov 19 2015, 4:18 PM

matmarex removed a project: Patch-For-Review.

Change 251018 merged by jenkins-bot:
HTMLForm: Do not render hidden elements as elements

https://gerrit.wikimedia.org/r/251018

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)).Nov 19 2015, 5:00 PM

Florian mentioned this in T129821: HTMLForm renders an unnecessary label element for elements without a label.Mar 13 2016, 11:00 PM