Page MenuHomePhabricator

Convert Special:RevisionDelete to OOUI
Open, NormalPublic

Description

This should go hand in hand with Special:Undelete

Event Timeline

matmarex created this task.Nov 4 2015, 7:54 PM
matmarex raised the priority of this task from to Normal.
matmarex updated the task description. (Show Details)
matmarex added a project: UI-Standardization.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2015, 7:54 PM
Florian added a subscriber: Florian.Nov 5 2015, 4:56 PM

This needs optgroup support in OOUI DropdownInputWidget, as far as I can see, that's not supported so far, right?

While OO.ui.DropdownInputWidget would benefit from having support for optgroup, I don't think this particular page needs it. My understanding here is limited, but I feel that the Common delete reasons heading is unnecessary and the functionality of the dropdown would be obvious to the user even without it.

A part of the UI is slightly tricky, when you select two revisions you get a table of radios.

Single revisionMultiple revisions

I was thinking of using a ButtonGroupWidget instead.

While OO.ui.DropdownInputWidget would benefit from having support for optgroup, I don't think this particular page needs it. My understanding here is limited, but I feel that the Common delete reasons heading is unnecessary and the functionality of the dropdown would be obvious to the user even without it.

I agree, I don't think it's necessary here as long as it's always those five possible options.

A part of the UI is slightly tricky, when you select two revisions you get a table of radios.

Single revisionMultiple revisions

I was thinking of using a ButtonGroupWidget instead.

Not sure if repeating four ButtonGroupWidgets with same Button labels (”(do not change)”/“Visible”/“Hidden”) is best representation.

Why is “Suppress data[…]” set to bold?

I agree, I don't think it's necessary here as long as it's always those five possible options.

Yep, anyway that issues is resolved - T135028: DropdownInputWidget: Provide optgroup support

Not sure if repeating four ButtonGroupWidgets with same Button labels (”(do not change)”/“Visible”/“Hidden”) is best representation.

Me neither. Any suggestions?

Why is “Suppress data[…]” set to bold?

I suppose its to signify that these setting should be used with caution. We could obviously take another approach.

Jayprakash12345 raised the priority of this task from Normal to Needs Triage.Apr 4 2018, 8:23 PM
Volker_E triaged this task as Normal priority.Apr 4 2018, 8:47 PM

Removing Front-end-Standards-Group, from here (above) it's a resources and priorities question and nothing the group can contribute to.

@Prtksxna For multiple revisions, I guess, having the labels first and introducing at least a slight zebra row coloring similar to CheckboxMatrix should make it better.

Prtksxna removed Prtksxna as the assignee of this task.Aug 7 2018, 4:37 AM

Sorry, won't be working on this for a while.

Volker_E updated the task description. (Show Details)Dec 18 2018, 2:32 AM

@Prtksxna Did you get to any start code-wise here?

@Prtksxna Did you get to any start code-wise here?

Its been a while, and I think I did. But I can't find any corresponding abandoned Gerrit patches or local branches, sorry! 😞