Page MenuHomePhabricator

Convert Special:UserRights to HTMLForm
Closed, ResolvedPublic

Description

Without Action

Before:
before.JPG (637×1 px, 60 KB)
and After:
after.JPG (637×1 px, 60 KB)

With Action

Before:
before1.JPG (639×1 px, 101 KB)
and After:
after1.JPG (635×1 px, 92 KB)

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 423991 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/core@master] Partially Convert Special:UserRights to OOUI

https://gerrit.wikimedia.org/r/423991

Change 518750 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/core@master] Start converting Special:UserRights to OOUI

https://gerrit.wikimedia.org/r/518750

Change 518750 abandoned by Majavah:
Start converting Special:UserRights to OOUI

https://gerrit.wikimedia.org/r/518750

The username form will be converted to OOUI through T341684.

@Tchanders should this be a "convert to Codex" task instead of "convert to OOUI"?

Having spoken with @Catrope, let's use this task to convert the special page(s) to HTMLForm (OOUI mode), then when Codex mode is ready, it should just be a case of switching modes.

Tchanders renamed this task from Convert Special:UserRights to OOUI to Convert Special:UserRights to HTMLForm.Oct 21 2025, 8:46 AM

Change #1198076 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] UserGroupsSpecialPage: Modernize view-groups panel

https://gerrit.wikimedia.org/r/1198076

Change #1198542 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] UserGroupsSpecialPage: Start modernizing edit-groups panel

https://gerrit.wikimedia.org/r/1198542

Change #1198543 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] UserGroupsSpecialPage: Remove unused method getCurrentUserGroupsText

https://gerrit.wikimedia.org/r/1198543

There are some patches to review, but there are also more to do - i.e. the form for edit view.

Change #1198076 merged by jenkins-bot:

[mediawiki/core@master] UserGroupsSpecialPage: Modernize view-groups panel

https://gerrit.wikimedia.org/r/1198076

Change #1198542 merged by jenkins-bot:

[mediawiki/core@master] UserGroupsSpecialPage: Start modernizing edit-groups panel

https://gerrit.wikimedia.org/r/1198542

Change #1198543 merged by jenkins-bot:

[mediawiki/core@master] UserGroupsSpecialPage: Remove unused method getCurrentUserGroupsText

https://gerrit.wikimedia.org/r/1198543

mszwarc subscribed.

All reviews have been done, moving back to In progress to reflect that.

Change #1202759 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] WIP UserGroupsSpecialPage: Modernize edit-groups panel form

https://gerrit.wikimedia.org/r/1202759

Change #1203010 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CentralAuth@master] SpecialGlobalGroupMembershipTest: Ensure tests pass with UI updates

https://gerrit.wikimedia.org/r/1203010

Change #423991 abandoned by Reedy:

[mediawiki/core@master] Partially Convert Special:UserRights to OOUI

https://gerrit.wikimedia.org/r/423991

Change #1203010 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] SpecialGlobalGroupMembershipTest: Ensure tests pass with UI updates

https://gerrit.wikimedia.org/r/1203010

Appearance of the OOUI version on mobile:

image.png (1×672 px, 90 KB)

Change #1203864 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] Replace userrights.css with userrights.less

https://gerrit.wikimedia.org/r/1203864

Change #1204931 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] userrights.less: Reduce margin on group expiry fields

https://gerrit.wikimedia.org/r/1204931

Change #1204932 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] Improve layout of UserGroupsSpecialPage ages on mobile

https://gerrit.wikimedia.org/r/1204932

Appearance of the OOUI version on mobile:

image.png (1×672 px, 90 KB)

Thanks. Here are screenshots of mobile with the latest changes, and also without any changes:

Latest changesNo changes
image.png (881×341 px, 61 KB)
image.png (564×343 px, 46 KB)

Change #1202759 merged by jenkins-bot:

[mediawiki/core@master] UserGroupsSpecialPage: Modernize edit-groups panel form

https://gerrit.wikimedia.org/r/1202759

Change #1203864 merged by jenkins-bot:

[mediawiki/core@master] Replace userrights.css with userrights.less

https://gerrit.wikimedia.org/r/1203864

Change #1204931 merged by jenkins-bot:

[mediawiki/core@master] userrights.less: Reduce margin on group expiry fields

https://gerrit.wikimedia.org/r/1204931

Change #1204932 merged by jenkins-bot:

[mediawiki/core@master] Improve layout of UserGroupsSpecialPage ages on mobile

https://gerrit.wikimedia.org/r/1204932

Could this please be done without making everything take up 2 or 3 times as much vertical space as it did in the previous version. All of these UI "modernization" things end up making things worse in that way in my opinion.

Could this please be done without making everything take up 2 or 3 times as much vertical space as it did in the previous version. All of these UI "modernization" things end up making things worse in that way in my opinion.

Thanks for your feedback, @Pppery! We have considered this point of view and were aware that the transition to OOUI would make the page longer. Apart from the technical implementation things, we considered two other factors:

  • The Special:UserRights page isn't a part of time-sensitive workflows – i.e. if we cause the user to spend more time going between UI components, no harm to the projects will be made (unlike with Special:Block or action=protect).
  • WCAG level AA (which is the level MediaWiki aims to meet) expects that clickable elements are at least 24x24px in size (and if not, then circles with 24px diameter centered on such elements don't intersect) – in the previous version, the checkboxes were much closer (approx. 18px center-to-center, may vary between browsers and skins).

A thing that we also thought about is to remove the "Expires:" header above the dropdowns, and instead to pull it into the item labels. In this scenario, the list would look like "Does not expire" / "Expires in 1 day" / "Expires in ..." / "Other expiration time" (shown below). Would such a change improve the page in your opinion?

CurrentWithout "Expires"
image.png (1×616 px, 76 KB)
image.png (1×597 px, 73 KB)

A thing that we also thought about is to remove the "Expires:" header above the dropdowns, and instead to pull it into the item labels. In this scenario, the list would look like "Does not expire" / "Expires in 1 day" / "Expires in ..." / "Other expiration time" (shown below). Would such a change improve the page in your opinion?

Removing the "Expires:" header looks clearly better to me.

Change #1213420 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/core@master] Fix broken mediawiki.special.userrights.js

https://gerrit.wikimedia.org/r/1213420

Change #1213420 merged by jenkins-bot:

[mediawiki/core@master] Fix broken mediawiki.special.userrights.js

https://gerrit.wikimedia.org/r/1213420

Change #1215682 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] UserGroupsSpecialPage: Improve i18n for expiry messages

https://gerrit.wikimedia.org/r/1215682

Change #1215682 merged by jenkins-bot:

[mediawiki/core@master] UserGroupsSpecialPage: Improve i18n for expiry messages

https://gerrit.wikimedia.org/r/1215682