Without Action
| Before: | and After: |
With Action
| Before: | and After: |
| matmarex | |
| Nov 5 2015, 5:52 PM |
| F70313024: image.png | |
| Nov 21 2025, 8:52 AM |
| F70313040: image.png | |
| Nov 21 2025, 8:52 AM |
| F70184498: image.png | |
| Nov 13 2025, 6:06 PM |
| F70184484: image.png | |
| Nov 13 2025, 6:06 PM |
| F70132536: image.png | |
| Nov 12 2025, 8:24 AM |
| F70113075: Screen Recording 2025-11-11 at 14.55.03.mov | |
| Nov 11 2025, 2:56 PM |
| F16677673: before.JPG | |
| Apr 4 2018, 5:34 PM |
| F16677671: after.JPG | |
| Apr 4 2018, 5:34 PM |
| Before: | and After: |
| Before: | and After: |
| rMW MediaWiki | |||
| rMW891df8ef9e32 Start converting Special:UserRights to OOUI | |||
Change 423991 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/core@master] Partially Convert Special:UserRights to OOUI
Change 518750 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/core@master] Start converting Special:UserRights to OOUI
I think it makes sense to complete this work, since we will be working on T405575: Share logic between Special:UserRights and Special:GlobalGroupMembership.
Having spoken with @Catrope, let's use this task to convert the special page(s) to HTMLForm (OOUI mode), then when Codex mode is ready, it should just be a case of switching modes.
Change #1198076 had a related patch set uploaded (by Tchanders; author: Tchanders):
[mediawiki/core@master] UserGroupsSpecialPage: Modernize view-groups panel
Change #1198542 had a related patch set uploaded (by Tchanders; author: Tchanders):
[mediawiki/core@master] UserGroupsSpecialPage: Start modernizing edit-groups panel
Change #1198543 had a related patch set uploaded (by Tchanders; author: Tchanders):
[mediawiki/core@master] UserGroupsSpecialPage: Remove unused method getCurrentUserGroupsText
There are some patches to review, but there are also more to do - i.e. the form for edit view.
Change #1198076 merged by jenkins-bot:
[mediawiki/core@master] UserGroupsSpecialPage: Modernize view-groups panel
Change #1198542 merged by jenkins-bot:
[mediawiki/core@master] UserGroupsSpecialPage: Start modernizing edit-groups panel
Change #1198543 merged by jenkins-bot:
[mediawiki/core@master] UserGroupsSpecialPage: Remove unused method getCurrentUserGroupsText
Change #1202759 had a related patch set uploaded (by Tchanders; author: Tchanders):
[mediawiki/core@master] WIP UserGroupsSpecialPage: Modernize edit-groups panel form
Change #1203010 had a related patch set uploaded (by Tchanders; author: Tchanders):
[mediawiki/extensions/CentralAuth@master] SpecialGlobalGroupMembershipTest: Ensure tests pass with UI updates
Change #423991 abandoned by Reedy:
[mediawiki/core@master] Partially Convert Special:UserRights to OOUI
Change #1203010 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] SpecialGlobalGroupMembershipTest: Ensure tests pass with UI updates
Change #1203864 had a related patch set uploaded (by Tchanders; author: Tchanders):
[mediawiki/core@master] Replace userrights.css with userrights.less
Change #1204931 had a related patch set uploaded (by Tchanders; author: Tchanders):
[mediawiki/core@master] userrights.less: Reduce margin on group expiry fields
Change #1204932 had a related patch set uploaded (by Tchanders; author: Tchanders):
[mediawiki/core@master] Improve layout of UserGroupsSpecialPage ages on mobile
Thanks. Here are screenshots of mobile with the latest changes, and also without any changes:
| Latest changes | No changes |
Change #1202759 merged by jenkins-bot:
[mediawiki/core@master] UserGroupsSpecialPage: Modernize edit-groups panel form
Change #1203864 merged by jenkins-bot:
[mediawiki/core@master] Replace userrights.css with userrights.less
Change #1204931 merged by jenkins-bot:
[mediawiki/core@master] userrights.less: Reduce margin on group expiry fields
Change #1204932 merged by jenkins-bot:
[mediawiki/core@master] Improve layout of UserGroupsSpecialPage ages on mobile
Moving this to Done since this should be tested via T409714: Update UserGroupAssignmentService to check restricted groups.
Could this please be done without making everything take up 2 or 3 times as much vertical space as it did in the previous version. All of these UI "modernization" things end up making things worse in that way in my opinion.
Thanks for your feedback, @Pppery! We have considered this point of view and were aware that the transition to OOUI would make the page longer. Apart from the technical implementation things, we considered two other factors:
A thing that we also thought about is to remove the "Expires:" header above the dropdowns, and instead to pull it into the item labels. In this scenario, the list would look like "Does not expire" / "Expires in 1 day" / "Expires in ..." / "Other expiration time" (shown below). Would such a change improve the page in your opinion?
| Current | Without "Expires" |
|---|---|
Thanks everyone - let's remove those heading and track this as T410845: Userrights special pages layout requires excessive scrolling.
Change #1213420 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/core@master] Fix broken mediawiki.special.userrights.js
Change #1213420 merged by jenkins-bot:
[mediawiki/core@master] Fix broken mediawiki.special.userrights.js
Change #1215682 had a related patch set uploaded (by Func; author: Func):
[mediawiki/core@master] UserGroupsSpecialPage: Improve i18n for expiry messages
Change #1215682 merged by jenkins-bot:
[mediawiki/core@master] UserGroupsSpecialPage: Improve i18n for expiry messages