Page MenuHomePhabricator
Create Task
Maniphest T117886

[Task] Don't fail when running job mediawiki-extensions-qunit with Wikidata
Closed, ResolvedPublic
Actions

Description

In T96264#1783853, @JanZerebecki wrote:

This requires also adding it to mediawiki-extensions-qunit which is currently failing for Wikidata:
https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/19035/consoleFull

@adrianheine said that these are probably the same failures that happen in Wikidata related qunit tests when UniversalLanguageSelector is enabled.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Added compatibility with DataValues JavaScript 0.8.0Thiemo Kreuz (WMDE)mediawiki/extensions/WikibaseJavaScriptApimaster+7 -3
Set QUnit.config.requireExpects to trueThiemo Kreuz (WMDE)mediawiki/extensions/Wikibasemaster+3 -4
Added compatibility with DataValues JavaScript 0.8.0Thiemo Kreuz (WMDE)data-values/value-viewmaster+6 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

JanZerebecki created this task.Nov 5 2015, 6:17 PM
JanZerebecki raised the priority of this task from to Medium.
JanZerebecki updated the task description. (Show Details)
JanZerebecki added projects: Wikidata-Sprint-2015-11-03, Wikidata.
JanZerebecki added subscribers: JanZerebecki, Aklapper, • adrianheine.
• adrianheine added projects: MediaWiki-extensions-WikibaseView, UniversalLanguageSelector.Nov 6 2015, 7:53 AM
• adrianheine set Security to None.
Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-11-17.Nov 16 2015, 2:39 PM
thiemowmde moved this task from Proposed to Backlog on the Wikidata-Sprint-2015-11-17 board.Nov 17 2015, 2:54 PM
Lydia_Pintscher added a project: Wikidata-Sprint-2015-12-01.Dec 1 2015, 10:14 AM
Lydia_Pintscher moved this task from Proposed to Backlog on the Wikidata-Sprint-2015-12-01 board.
hashar mentioned this in T120349: Wikibase QUnit failure blocks Content translation CI.Dec 4 2015, 12:02 PM
aude moved this task from Backlog to Doing on the Wikidata-Sprint-2015-12-01 board.Dec 4 2015, 4:57 PM
JanZerebecki added a comment.Dec 8 2015, 4:11 PM

Still fails after recent changes: https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/22105/console

• adrianheine added a comment.Dec 9 2015, 9:29 AM

Ok, this is about something completely different, and if I'd have bothered to actually look I'd have seen it. core's QUnit test runner requires all test cases to state how many assertions they expect; Wikibase's does not, and so we didn't specify it in most of our tests. I'll prepare patches.

• adrianheine added a comment.Dec 9 2015, 10:13 AM

https://github.com/wmde/WikibaseDataModelJavaScript/pull/36

JanZerebecki mentioned this in T120907: Wikibase Qunit test fails with CX + ULS.Dec 9 2015, 12:27 PM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Dec 11 2015, 10:18 AM
thiemowmde added a project: Wikibase-DataModel-JavaScript.Dec 17 2015, 10:47 AM
thiemowmde subscribed.

https://github.com/wmde/WikibaseDataModelJavaScript/pull/36 is merged. Does this need a release? Probably yes.

How can I check if this fixes all errors?

thiemowmde moved this task from Doing to Backlog on the Wikidata-Sprint-2015-12-01 board.Dec 17 2015, 10:47 AM
JanZerebecki added a comment.Dec 18 2015, 7:48 PM

By commenting on a change in Wikidata with: check experimental

• adrianheine added a comment.Jan 7 2016, 10:34 AM

This won't fix all errors, we need to do the same for all JS repos.

• adrianheine added a comment.Jan 7 2016, 12:49 PM

https://gerrit.wikimedia.org/r/#/c/262891/
https://gerrit.wikimedia.org/r/#/c/262890/
https://github.com/wmde/DataValuesJavascript/pull/90

• adrianheine edited projects, added: ValueView; removed: UniversalLanguageSelector.Jan 7 2016, 12:49 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-01-19.Jan 19 2016, 2:02 PM
Tobi_WMDE_SW moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-01-19 board.
• adrianheine added a comment.Jan 27 2016, 10:12 AM
In T117886#1891371, @JanZerebecki wrote:

By commenting on a change in Wikidata with: check experimental

If you meant Wikibase, this does not work currently. Maybe jobs got re-deployed?

gerritbot subscribed.Jan 27 2016, 10:34 AM

Change 263353 had a related patch set uploaded (by Adrian Lang):
[DNM] Set QUnit.config.requireExpects to true

https://gerrit.wikimedia.org/r/263353

gerritbot added a project: Patch-For-Review.Jan 27 2016, 10:34 AM
gerritbot added a comment.Jan 27 2016, 12:04 PM

Change 266700 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Added compatibility with DataValues JavaScript 0.8.0

https://gerrit.wikimedia.org/r/266700

thiemowmde added a comment.Jan 27 2016, 12:05 PM

More patches for review:

And then, hopefully, https://gerrit.wikimedia.org/r/263353.

gerritbot added a comment.Jan 27 2016, 12:19 PM

Change 266700 merged by jenkins-bot:
Added compatibility with DataValues JavaScript 0.8.0

https://gerrit.wikimedia.org/r/266700

gerritbot added a comment.Jan 27 2016, 1:55 PM

Change 266718 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Added compatibility with DataValues JavaScript 0.8.0

https://gerrit.wikimedia.org/r/266718

gerritbot added a comment.Jan 27 2016, 2:07 PM

Change 266718 merged by jenkins-bot:
Added compatibility with DataValues JavaScript 0.8.0

https://gerrit.wikimedia.org/r/266718

gerritbot added a comment.Jan 27 2016, 2:30 PM

Change 263353 merged by jenkins-bot:
Set QUnit.config.requireExpects to true

https://gerrit.wikimedia.org/r/263353

• Jonas renamed this task from don't fail when running job mediawiki-extensions-qunit with Wikidata to [Task] Don't fail when running job mediawiki-extensions-qunit with Wikidata.Jan 27 2016, 2:32 PM
• Jonas assigned this task to thiemowmde.
• Jonas moved this task from Backlog to Review on the Wikidata-Sprint-2016-01-19 board.
JanZerebecki added a comment.Jan 28 2016, 5:52 AM
In T117886#1968965, @adrianheine wrote:
In T117886#1891371, @JanZerebecki wrote:

By commenting on a change in Wikidata with: check experimental

If you meant Wikibase, this does not work currently. Maybe jobs got re-deployed?

No I meant Wikidata, as Wikibase needs composer, but there is no composer variant of those jobs.

JanZerebecki added a comment.Jan 28 2016, 6:21 AM

Wikidata build with all changes and the mentioned experimental run: https://gerrit.wikimedia.org/r/#/c/266990/

JanZerebecki closed this task as Resolved.Jan 28 2016, 6:22 AM
JanZerebecki moved this task from Review to Done on the Wikidata-Sprint-2016-01-19 board.Jan 28 2016, 6:28 AM
• adrianheine added a comment.Jan 28 2016, 8:48 AM

Yeah :)

JanZerebecki mentioned this in T125655: VE QUnit tests fail on 1.27.0-wmf.12 branch due to Wikidata branch cut issue.Feb 3 2016, 4:13 PM
JanZerebecki mentioned this in T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail.Feb 8 2016, 7:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits