Page MenuHomePhabricator
Create Task
Maniphest T117985

Fix easy problems reported by RuboCop in PageTriage
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Fixed Style/RegexpLiteral RuboCop offensemediawiki/extensions/PageTriagemaster+1 -17
Fixed Style/StringLiterals RuboCop offensemediawiki/extensions/PageTriagemaster+30 -37
Updated RuboCop to the latest versionmediawiki/extensions/PageTriagemaster+40 -18
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Nov 6 2015, 4:14 PM
zeljkofilipin claimed this task.
zeljkofilipin raised the priority of this task from to Medium.
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin added projects: Browser-Tests-Infrastructure, PageTriage.
zeljkofilipin subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptNov 6 2015, 4:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
zeljkofilipin removed zeljkofilipin as the assignee of this task.Nov 6 2015, 4:16 PM
zeljkofilipin mentioned this in T91485: Fix easy problems reported by RuboCop.Nov 6 2015, 4:19 PM
zeljkofilipin edited projects, added Browser-Tests, Ruby; removed Browser-Tests-Infrastructure.Nov 6 2015, 5:58 PM
zeljkofilipin set Security to None.
zeljkofilipin claimed this task.Nov 25 2015, 1:09 PM
zeljkofilipin added a project: Browser-Tests-Infrastructure.
zeljkofilipin moved this task from Inbox to Next on the Browser-Tests-Infrastructure board.
gerritbot subscribed.Nov 25 2015, 2:43 PM

Change 255387 had a related patch set uploaded (by Zfilipin):
Updated RuboCop to the latest version

https://gerrit.wikimedia.org/r/255387

gerritbot added a project: Patch-For-Review.Nov 25 2015, 2:43 PM

Change 255388 had a related patch set uploaded (by Zfilipin):
Fixed Style/StringLiterals RuboCop offense

https://gerrit.wikimedia.org/r/255388

gerritbot added a comment.Nov 25 2015, 2:43 PM

Change 255389 had a related patch set uploaded (by Zfilipin):
Fixed Style/RegexpLiteral RuboCop offense

https://gerrit.wikimedia.org/r/255389

zeljkofilipin moved this task from Next to In Progress on the Browser-Tests-Infrastructure board.Nov 25 2015, 2:45 PM
zeljkofilipin moved this task from In Progress to Code Review on the Browser-Tests-Infrastructure board.
gerritbot added a comment.Nov 25 2015, 4:03 PM

Change 255387 merged by jenkins-bot:
Updated RuboCop to the latest version

https://gerrit.wikimedia.org/r/255387

gerritbot added a comment.Nov 25 2015, 4:03 PM

Change 255388 merged by jenkins-bot:
Fixed Style/StringLiterals RuboCop offense

https://gerrit.wikimedia.org/r/255388

gerritbot added a comment.Nov 25 2015, 4:04 PM

Change 255389 merged by jenkins-bot:
Fixed Style/RegexpLiteral RuboCop offense

https://gerrit.wikimedia.org/r/255389

hashar closed this task as Resolved.Nov 25 2015, 4:06 PM
hashar subscribed.

I have approved all related patches and build the couple browser tests jobs for PageTriage:

https://integration.wikimedia.org/ci/job/browsertests-PageTriage-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/
https://integration.wikimedia.org/ci/job/browsertests-PageTriage-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/

Both pass.

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)).Nov 25 2015, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL