Page MenuHomePhabricator

Fix jscs error
Closed, InvalidPublic

Description

When updating to grunt jscs 2.3.0 it is bringing jscs errors.

Steps to reproduce

Actual results

  • It is coming up with this error

17:35:55 Running "jscs:all" (jscs) task

17:36:05 Redundant return statement at ./resources/src/jquery/jquery.suggestions.js :
17:36:05 23 | * @method suggestions
17:36:05 24 | * @chainable
17:36:05 25 | * @return {jQuery}
17:36:05 -----------^
17:36:05 26 | *
17:36:05 27 | * @param {Object} options
17:36:05 Expected $ but got options at ./resources/src/jquery/jquery.suggestions.js :
17:36:05 25 | * @return {jQuery}
17:36:05 26 | *
17:36:05 27 | * @param {Object} options
17:36:05 ---------------------------^
17:36:05 28 | *
17:36:05 29 | * @param {Function} [options.fetch] Callback that should fetch suggestions and set the suggestions
17:36:05 >> 2 code style errors found!
17:36:05 Warning: Task "jscs:all" failed. Use --force to continue.

Expected results

  • It should pass the test with success.

Event Timeline

Paladox raised the priority of this task from to Needs Triage.
Paladox updated the task description. (Show Details)
Paladox subscribed.

@Paladox: Coul you elaborate which code in an MediaWiki extension needs to be fixed here?
The link you posted goes to MediaWiki core...

Paladox set Security to None.

@Aklapper sorry I put in the wrong project. It was mediawiki core.

Umherirrender subscribed.

mediawiki/core is using eslint now