Page MenuHomePhabricator

VE preview on Flow pages take too long (1min+) to load in debug mode
Closed, DuplicatePublic

Description

It took more than 20 seconds to load this page in debug mode:
https://pt.wikipedia.org/w/index.php?title=T%C3%B3pico:Ss6qo681yhzwceha&action=undo-edit-post&topic_startId=ss6qo6cqbsxwwjta&topic_endId=ss6w8enh3dnd9ghv

This is not the first time I had to wait that amount of time to load the comment form in Flow pages when in debug mode...

Event Timeline

He7d3r created this task.Nov 7 2015, 7:41 PM
He7d3r raised the priority of this task from to Low.
He7d3r updated the task description. (Show Details)
He7d3r added a project: StructuredDiscussions.
He7d3r added a subscriber: He7d3r.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptNov 7 2015, 7:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
He7d3r renamed this task from Flow pages take too long (20s+) to load in debug mode to VE preview on Flow pages take too long (1min+) to load in debug mode.Nov 7 2015, 7:47 PM
He7d3r added a project: VisualEditor.
He7d3r set Security to None.

I would prefer it be faster too as a developer, but debug mode is not for normal usage. Also, this is really probably 90+% on the VE side, and not easy to fix (though there are bugs that would obsolete it like T47514: ResourceLoader: Implement support for Source Maps).

Per @Krinkle, you should not ever use debug mode and it's going away. Or something.

We might be able to not load (though a lot is accessible through keyboard shortcuts even though it appears not to be visible) or lazy-load more stuff as well.

It might also help to change which VE target we use (there is a bug for this somewhere).

So putting back Flow for now.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptNov 9 2015, 5:02 PM

Well, how else can I find the source of bugs such as T110182 if not using debug mode?

As a developer, I definitely understand the need for debug mode. I just use it on an as-needed basis, though (sometimes using your script), and deal with the VE slowness. As I said in my follow-up, there are some things we can maybe do about this (short- and long-term).

Well, how else can I find the source of bugs such as T110182 if not using debug mode?

With the source maps which are meant to have arrived years ago; see T47514: ResourceLoader: Implement support for Source Maps towards the top of this task's dependency chain.