Page MenuHomePhabricator

WikiEditor's search and replace box stays open after moving from source editing to visual editing
Closed, ResolvedPublic1 Estimated Story Points

Description

To reproduce:

  • Open a page in source editing with the WikiEditor toolbar.
  • Open the Search and Replace dialog from the WikiEditor toolbar.
  • Click the "Edit" tab and move to visual editing.

Observed: The dialog is still visible.
Expected: WikiEditor's dialog is alien to VisualEditor, so it should disappear before moving to VisualEditor.

Event Timeline

Amire80 raised the priority of this task from to Needs Triage.
Amire80 updated the task description. (Show Details)
Amire80 added projects: VisualEditor, WikiEditor.
Amire80 added a subscriber: Amire80.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Change 253814 had a related patch set uploaded (by Esanders):
Edit mode switching: Auto-close jQuery.UI dialogs before switching

https://gerrit.wikimedia.org/r/253814

Change 253814 merged by jenkins-bot:
Edit mode switching: Auto-close jQuery.UI dialogs before switching

https://gerrit.wikimedia.org/r/253814