Page MenuHomePhabricator

Inconsistent 'Cancel' button color for 'Edit title' and 'Edit post'/ 'Reply'
Closed, ResolvedPublic


  1. Open any Flow board page.
  2. Click 'Edit title' - the Cancel button is black.
  3. Open 'Edit' post or click 'Reply' to post - the Cancel button is red. The hover-over color is different too.

Note: does not matter whether a text area will be clicked in(focused) or not.

'Cancel' button is presented as two different elements:
In Title:
<button data-role="cancel" type="reset" data-flow-interactive-handler="cancelForm" class="mw-ui-button mw-ui-destructive mw-ui-quiet">Cancel</button>

vs in Edit post:

<span class="oo-ui-iconElement-icon oo-ui-image-destructive"></span>

Event Timeline

Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)

Change 260006 had a related patch set uploaded (by Sbisson):
[WIP] Various fixes to edit-title

Change 260006 merged by jenkins-bot:
Various fixes to edit-title

Checked in betalabs - 'Cancel' label color is consistently red now for both - 'Edit title' and 'Edit post'/ 'Reply'

Catrope added a subscriber: Catrope.