Page MenuHomePhabricator
Create Task
Maniphest T118475

Quick survey breaks h2 and infobox positioning
Closed, ResolvedPublic
Actions

Description

Contains the following fragment:

@media all and (min-width:768px){.ext-qs-loader-bar,.ext-quick-survey-panel{margin-left:1.4em;width:300px;clear:right;float:right}.infobox,.last-modified-bar,h2{clear:both}}"

This forces h2 AND the infobox to clear, which is NOT as expected. See for instance:
https://en.wikipedia.org/wiki/Cliff_Robertson

https://en.wikipedia.org/wiki/Edmond_Hamilton

Please remove the clear:both from both the infobox and the h2 and find a different way to achieve the desired result.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/QuickSurveysmaster+0 -7Fix clear:both breaking pages
mediawiki/extensions/QuickSurveyswmf/1.27.0-wmf.7+0 -7Fix clear:both breaking pages
mediawiki/extensions/QuickSurveysdev+0 -7Fix clear:both breaking pages
mediawiki/extensions/QuickSurveyswmf/1.27.0-wmf.6+0 -7Fix clear:both breaking pages
Customize query in gerrit

Related Objects

Event Timeline

TheDJ created this task.Nov 12 2015, 5:07 PM
TheDJ raised the priority of this task from to Unbreak Now!.
TheDJ updated the task description. (Show Details)
TheDJ added a project: QuickSurveys.
TheDJ added a subscriber: TheDJ.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 12 2015, 5:07 PM
TheDJ renamed this task from Quick survey breaks h2 positioning to Quick survey breaks h2 and infobox positioning.Nov 12 2015, 5:17 PM
TheDJ updated the task description. (Show Details)
TheDJ set Security to None.
TheDJ updated the task description. (Show Details)Nov 12 2015, 5:22 PM
• jhobs claimed this task.Nov 12 2015, 5:35 PM
• jhobs updated the task description. (Show Details)
• jhobs added a project: Reading Web Sprint 60 - Boom Headshot!.
• jhobs moved this task from Needs Analysis to Doing on the Reading Web Sprint 60 - Boom Headshot! board.
mb added a subscriber: mb.Nov 12 2015, 6:09 PM
gerritbot added a subscriber: gerritbot.Nov 12 2015, 6:27 PM

Change 252736 had a related patch set uploaded (by Jhobs):
Fix clear:both breaking pages

https://gerrit.wikimedia.org/r/252736

gerritbot added a comment.Nov 12 2015, 6:49 PM

Change 252736 merged by jenkins-bot:
Fix clear:both breaking pages

https://gerrit.wikimedia.org/r/252736

• jhobs added a comment.Nov 12 2015, 8:16 PM

The fix above has been scheduled for the evening SWAT.

TheDJ added a comment.Nov 12 2015, 8:33 PM

For those less familiar with the operations. SWAT are the two workday timeslots in which 'out-of-band' deploys to the WMF websites are made.

PrimeHunter added a subscriber: PrimeHunter.Nov 12 2015, 9:07 PM

I have made a temporary fix to the English Wikipedia:
https://en.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=690352708&oldid=688903518
It adds this:
.infobox,
.last-modified-bar,
h2 {

clear: none !important;

}

Mike_Peel added a subscriber: Mike_Peel.Nov 12 2015, 9:23 PM
In T118475#1802022, @PrimeHunter wrote:

I have made a temporary fix to the English Wikipedia

Note that this temporary fix was quickly undone:
https://en.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=690356871&oldid=690352708

Edokter added a subscriber: Edokter.Nov 12 2015, 9:55 PM

Yeah, I removed that, as it !forced any clears to none, which interfered with some templates.

gerritbot added a comment.Nov 13 2015, 12:02 AM

Change 252874 had a related patch set uploaded (by Catrope):
Fix clear:both breaking pages

https://gerrit.wikimedia.org/r/252874

gerritbot added a comment.Nov 13 2015, 12:26 AM

Change 252874 merged by Catrope:
Fix clear:both breaking pages

https://gerrit.wikimedia.org/r/252874

Mike_Peel added a comment.Nov 13 2015, 12:32 AM

The fix appears to be working nicely - thank you!

• jhobs added a comment.Nov 13 2015, 12:37 AM

There was a temporary fix applied that can be removed now that this has been deployed. Thank you to whoever applied that!

phuedx closed this task as Resolved.Nov 13 2015, 9:33 AM
phuedx added a subscriber: phuedx.
In T118475#1802744, @Mike_Peel wrote:

The fix appears to be working nicely - thank you!

Thanks for confirming that the fix works @Mike_Peel. I've also just double-checked myself.

gerritbot added a comment.Nov 19 2015, 8:10 PM

Change 254184 had a related patch set uploaded (by Legoktm):
Fix clear:both breaking pages

https://gerrit.wikimedia.org/r/254184

gerritbot added a comment.Nov 19 2015, 8:10 PM

Change 254186 had a related patch set uploaded (by Legoktm):
Fix clear:both breaking pages

https://gerrit.wikimedia.org/r/254186

Legoktm reopened this task as Open.Nov 19 2015, 8:11 PM
Legoktm added subscribers: 20after4, Legoktm.

This was not merged to master and regressed again when the train went out today. @20after4 is backporting it right now.

gerritbot added a comment.Nov 19 2015, 8:18 PM

Change 254184 merged by Legoktm:
Fix clear:both breaking pages

https://gerrit.wikimedia.org/r/254184

gerritbot added a comment.Nov 19 2015, 8:19 PM

Change 254186 merged by jenkins-bot:
Fix clear:both breaking pages

https://gerrit.wikimedia.org/r/254186

mmodell added a subscriber: mmodell.Nov 19 2015, 8:23 PM

Patch has been deployed.

Legoktm closed this task as Resolved.Nov 19 2015, 8:25 PM

Thanks @mmodell. I've also backported this into master so we don't regress again in wmf.8.

Mike_Peel added a comment.Nov 19 2015, 8:25 PM

It looks like the fix is working properly again - thank you! :-)

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJun 11 2018, 8:23 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL