Page MenuHomePhabricator

[Task] Split RDF mapping code into separate classes per type
Closed, ResolvedPublic

Description

RDF mappings for the different value types (and property data types) is currently located in two big classes, SimpleValueRdfBuilder and ComplexValueRdfBuilder. They should be split up by data type, to improve maintainability and testability. This would also make it more streight forward to add mappings for new data types.

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

daniel created this task.Nov 12 2015, 9:07 PM
daniel claimed this task.
daniel raised the priority of this task from to Normal.
daniel updated the task description. (Show Details)
daniel added subscribers: Tobi_WMDE_SW, hoo, Smalyshev and 4 others.

Change 252026 had a related patch set uploaded (by Daniel Kinzler):
[WIP] Split SimpleValueRdfBuilder and ComplexValueRdfBuilder

https://gerrit.wikimedia.org/r/252026

daniel renamed this task from Split RDF mapping code into separate classes per type to [Task] Split RDF mapping code into separate classes per type.Nov 12 2015, 9:11 PM
daniel set Security to None.

@daniel so this is in doing?

@Tobi_WMDE_SW I split this out of the original patch for T112083. It's unclear to me whether we want to commit to this in the current sprint. I'm confident that I can get the code finished on monday, but we'll not get this through review before the sprint ends. So, what do you recommend? Commit to this and keep working on it Kanban-style, or push it into the next sprint Scrum-style?

Change 252026 merged by jenkins-bot:
Split SimpleValueRdfBuilder and ComplexValueRdfBuilder

https://gerrit.wikimedia.org/r/252026

adrianheine closed this task as Resolved.Nov 25 2015, 8:19 AM
adrianheine added a subscriber: adrianheine.