Page MenuHomePhabricator

Add suffix for Api QueryAllImages
Closed, DeclinedPublic

Description

Add a suffix to API QueryAllImages (much like prefix works).

Patch is on it's way

Related Objects

Event Timeline

Cblair91 raised the priority of this task from to Needs Triage.
Cblair91 updated the task description. (Show Details)
Cblair91 added a project: MediaWiki-Action-API.
Cblair91 subscribed.

This isn't going to be nice database wise, the suffixes won't be indexed...

See also T12808 for why we don't have Special:SuffixIndex

I suppose we could tag is as being an expensive call? Would still be nice to have the availability for it to be there.

Change 253079 had a related patch set uploaded (by Gerrit Patch Uploader):
Add suffix to ApiQueryAllImages.

https://gerrit.wikimedia.org/r/253079

Patch above is half-complete, submitting fix on top which contains API field.

See my updated comment above. Maybe hidden behind $wgMiserMode, but then it's not gonna be there on wikipedia wikis et al

T12808#1218828 for a possible solution

Hmm, I can see the issue with active indexing causing it to run slow. Still, surely it's implementable if it's flagged as an expensive call.

Hmm, I can see the issue with active indexing causing it to run slow. Still, surely it's implementable if it's flagged as an expensive call.

Flagged as expensive where?

Well there are other API parameters that could be classed as "expensive", since they don't call indexed columns. Surely it'd be classed as the same thing?

Well there are other API parameters that could be classed as "expensive", since they don't call indexed columns. Surely it'd be classed as the same thing?

Such as?

There shouldn't be any that are doing unindexed db queries

The API does some variance on "slow queries" and "fast queries", but I wouldn't call this the same thing at all

	const LIMIT_BIG1 = 500; // Fast query, std user limit
	const LIMIT_BIG2 = 5000; // Fast query, bot/sysop limit
	const LIMIT_SML1 = 50; // Slow query, std user limit
	const LIMIT_SML2 = 500; // Slow query, bot/sysop limit

The answer is still the same as T12808#153486, effectively. Just most wikis (unless they are commons) won't have nearly as many files as pages...

Anomie claimed this task.
Anomie subscribed.

This isn't going to happen in MediaWiki core unless someone figures out a way to make T12808 happen in MediaWiki core, due to SQL query inefficiency. Note CirrusSearch isn't in MediaWiki core, but someone could use action=search on a wiki with CirrusSearch installed to make use of such a workaround.

Arguments along the lines of "WP:OTHERCRAPEXISTS" carry no more weight here than they do in enwiki deletion discussions.

Change 253079 abandoned by Thiemo Kreuz (WMDE):
Add suffix to ApiQueryAllImages.

Reason:
Declined.

https://gerrit.wikimedia.org/r/253079