WrappedString: Throw an exception if suffix/prefix does not match the wrapped string
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bawolff
	Nov 14 2015, 11:23 PM

Description

Not sure what appropriate project is for wikimedia/wrappedString library. Do i even file this on phab or somewhere else?

I was recently experimenting with some code, and i accidentally changed the value of a wrapped string, without changing its prefix. This caused some subtle breakage without it being immediately obvious what the cause was. I think it would be much nicer for the programmer if wrapped string threw an exception if the prefix or suffix isnt actually the prefix or suffix of the respective wrappedstring

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Throw upon invalid prefix/suffix	WrappedString	master	+31 -4

Customize query in gerrit

Related Objects

Mentioned In: T200506: Previewing a non-style-only gadget that you already have enabled causes a syntax error
Mentioned Here: rGWST46e7b3d36f65: [BREAKING CHANGE] Consider content to include prefix/suffix

Event Timeline

Bawolff created this task.Nov 14 2015, 11:23 PM

Bawolff raised the priority of this task from to Needs Triage.

Bawolff updated the task description. (Show Details)

Bawolff added a project: good first task.

Bawolff subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 14 2015, 11:23 PM

@Bawolff: Where exactly is the codebase of this?

https://gerrit.wikimedia.org/r/#/q/project:WrappedString,n,z

Meh, not even Utilities-code-utils covers this. :( No idea where it expects its bug reports. Or who is maintainer.

@Krinkle is the author, I presume he is the maintainer too.

In the initial version, the prefix/suffix was by design matching as they were separate parameters. This was changed in v2.0 with rGWST46e7b3d36f65: [BREAKING CHANGE] Consider content to include prefix/suffix / https://gerrit.wikimedia.org/r/228182.

Krinkle renamed this task from WrappedString should throw an exception if suffix/prefix is not actually a suffix/prefix of the wrapped string to WrappedString: Throw an exception if suffix/prefix does not match the wrapped string.Nov 27 2015, 3:43 PM

Krinkle added a project: WMF-General-or-Unknown.

Krinkle set Security to None.

• Mattflaschen-WMF added a project: Ladies-That-FOSS-MediaWiki.Oct 28 2016, 9:41 PM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptOct 28 2016, 9:41 PM

Krinkle edited projects, added MediaWiki-libs-WrappedString; removed WMF-General-or-Unknown.Aug 7 2018, 4:04 PM

Krinkle mentioned this in T200506: Previewing a non-style-only gadget that you already have enabled causes a syntax error.Aug 7 2018, 4:08 PM

Krinkle added a project: Performance-Team.

• Imarlier moved this task from Inbox, needs triage to To-do: Goals, prioritized next 4 Quarters on the Performance-Team board.Aug 13 2018, 8:23 PM

Krinkle triaged this task as Low priority.Jun 6 2019, 11:05 AM

Krinkle moved this task from To-do: Goals, prioritized next 4 Quarters to Backlog: Maintenance, non-prioritized on the Performance-Team board.

• Gilles added a project: EngProd-Virtual-Hackathon.May 20 2020, 4:48 PM

Change 597835 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[WrappedString@master] tests: Observe behaviour upon invalid input