The labelRenderer function as used in EntityRenderer can also return nil, the functions calling need to handle that. Also it should be documented.
Example errors:
Lua error in EntityRenderer.lua at line 148: attempt to concatenate a nil value.
Lua error in EntityRenderer.lua at line 67: attempt to concatenate a nil value.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Show entityId if no label provided | mediawiki/extensions/ArticlePlaceholder | master | +9 -1 |
We will have to decide first, what should happen if there is no label in the language.
For the labelRenderer mw.wikibase.label is used. It should make use of the fallback chain.
It doesn't make much sense to display the entity id if there is no label, I assume. It would be pretty confusing to see an id without context.
So should we in case of the data not being translated just "hide" it by not displaying it? I guess this is the only option we have, but will be very messy when it comes to limiting results as in T117556 because the number of statements existing might then differ from the number of statements we are actually showing.
As a quick fix, I will make a patch to display the entity id, so it can be tested properly. But as mentioned before, I don't think that's the way we want to display it in the end. (Therefore, the patch shouldn't be merged, too.)
Change 254945 had a related patch set uploaded (by Lucie Kaffee):
Show entityId if no label provided
We should not hide information if it doesn't have a label. We would get into situations where a person just has one child for example while they have several. We should do the same thing we do in articles right now when no label is defined in the language.