Page MenuHomePhabricator

Undeletion of "Add-on" at dewiki fails
Closed, ResolvedPublic

Description

@doctaxon tried to undelete this page (https://de.wikipedia.org/w/index.php?title=Add-on), but there was an error:

2015-11-16 16:23:25 mw1179 dewiki exception ERROR: [8cacb543] /w/index.php?title=Spezial:Wiederherstellen&action=submit   MWException from line 1512 of /srv/mediawiki/php-1.27.0-wmf.6/includes/Revision.php: Content of Add-on is not valid! Content model is wikitext {"exception_id":"8cacb543"} 
[Exception MWException] (/srv/mediawiki/php-1.27.0-wmf.6/includes/Revision.php:1512) Content of Add-on is not valid! Content model is wikitext
  #0 /srv/mediawiki/php-1.27.0-wmf.6/includes/Revision.php(1369): Revision->checkContentModel()
  #1 /srv/mediawiki/php-1.27.0-wmf.6/includes/specials/SpecialUndelete.php(607): Revision->insertOn(DatabaseMysqli)
  #2 /srv/mediawiki/php-1.27.0-wmf.6/includes/specials/SpecialUndelete.php(385): PageArchive->undeleteRevisions(array, boolean, string)
  #3 /srv/mediawiki/php-1.27.0-wmf.6/includes/specials/SpecialUndelete.php(1655): PageArchive->undelete(array, string, array, boolean, User)
  #4 /srv/mediawiki/php-1.27.0-wmf.6/includes/specials/SpecialUndelete.php(825): SpecialUndelete->undelete()
  #5 /srv/mediawiki/php-1.27.0-wmf.6/includes/specialpage/SpecialPage.php(384): SpecialUndelete->execute(NULL)
  #6 /srv/mediawiki/php-1.27.0-wmf.6/includes/specialpage/SpecialPageFactory.php(553): SpecialPage->run(NULL)
  #7 /srv/mediawiki/php-1.27.0-wmf.6/includes/MediaWiki.php(280): SpecialPageFactory::executePath(Title, RequestContext)
  #8 /srv/mediawiki/php-1.27.0-wmf.6/includes/MediaWiki.php(704): MediaWiki->performRequest()
  #9 /srv/mediawiki/php-1.27.0-wmf.6/includes/MediaWiki.php(506): MediaWiki->main()
  #10 /srv/mediawiki/php-1.27.0-wmf.6/index.php(41): MediaWiki->run()
  #11 /srv/mediawiki/w/index.php(3): include(string)
  #12 {main}

Event Timeline

Luke081515 updated the task description. (Show Details)
Luke081515 raised the priority of this task from to Needs Triage.
Luke081515 added a project: Operations.
Luke081515 added subscribers: Luke081515, doctaxon.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 16 2015, 4:50 PM
Luke081515 triaged this task as Unbreak Now! priority.Nov 16 2015, 4:50 PM
Reedy updated the task description. (Show Details)Nov 16 2015, 4:50 PM
Reedy set Security to None.
doctaxon added a comment.EditedNov 16 2015, 4:53 PM

but it's possible to undelete other articles in all namespaces

Reedy added a subscriber: Reedy.Nov 16 2015, 5:02 PM

content_model and content_format seem to be the default in all cases (ie NULL). So this shouldn't be anything out of the ordinary for MW

mysql:wikiadmin@db1070 [dewiki]> select ar_content_model, ar_content_format from archive where ar_title = 'Add-on';
+------------------+-------------------+
| ar_content_model | ar_content_format |
+------------------+-------------------+
| NULL             | NULL              |
| NULL             | NULL              |
| NULL             | NULL              |

Can you restore the revisions otherwise and import back them to lemma Add-on ?

Change 253470 had a related patch set uploaded (by Hoo man):
Don't claim model validation failed if the content couldn't be loaded

https://gerrit.wikimedia.org/r/253470

Change 253475 had a related patch set uploaded (by Reedy):
Don't claim model validation failed if the content couldn't be loaded

https://gerrit.wikimedia.org/r/253475

Noting the patches above (to master, and cherry pick to deployment branch) don't actually fix the issue, they just improve the debugging, and give us a better error message so we know where to actually look more specifically

Change 253470 merged by jenkins-bot:
Don't claim model validation failed if the content couldn't be loaded

https://gerrit.wikimedia.org/r/253470

Change 253475 merged by jenkins-bot:
Don't claim model validation failed if the content couldn't be loaded

https://gerrit.wikimedia.org/r/253475

Reedy lowered the priority of this task from Unbreak Now! to High.Nov 16 2015, 10:57 PM
hoo closed this task as Resolved.Nov 16 2015, 11:21 PM
hoo claimed this task.
hoo removed a project: Patch-For-Review.

The underlying problem here was, that we can't load the content for a certain revision. I've filled T118789 for that.