Page MenuHomePhabricator

It should be possible to turn off link previews on desktop
Closed, InvalidPublic

Description

If a user doesn't like link previews they can opt out of link previews.

Suggested: "Don't show this again" text shows at bottom of the popup and it can be toggled on/off in mobile settings
Needed: Design showing how

see: T113242 for same on mobile

Event Timeline

Jhernandez assigned this task to Jdlrobson.
Jhernandez raised the priority of this task from to High.
Jhernandez updated the task description. (Show Details)
Jhernandez added subscribers: JKatzWMF, Jdlrobson, Prtksxna and 5 others.
JKatzWMF updated the task description. (Show Details)Nov 16 2015, 5:32 PM
JKatzWMF set Security to None.

Isn't this already possible through (1) the beta features panel, (2) the settings icon on the Hovercard?

Hi @Prtksxna good to 'hear' your voice again :)

While it is true one can turn off hovercards in the popup themselves, we need a place in settings (for turning it back on, for one thing). Once we move the feature out of beta, that will no longer be the place where people turn it on or off.

Quiddity added a subscriber: Quiddity.EditedNov 18 2015, 1:27 AM

@JKatzWMF The confusion here, is partially because the task description here is just a copy&paste of the mobile task... ;-)

What Prtksxna is referring to, is the already existing method of turning Hovercards on and off, on desktop, that even works for logged-out users (e.g. if the wiki has hovercards enabled by default for everyone). I.e. Click the settings/"cog" icon on a hovercard, and you can opt-out from there. See screenshots at https://www.mediawiki.org/wiki/Beta_Features/Hovercards#Enable.2FDisable for how a logged-out user can opt-back-in.
This is exactly the same way that https://www.mediawiki.org/wiki/Reference_Tooltips works.

@Quiddity yes, we are trying to think of link preview and hovercards as the
same thing (they should probably all be classified under the link preview
name, though- hovercards is a specific delivery mechanism, while link
preview speaks to the user value)

I stand corrected on whether or not a user can opt back in to hovercards on
desktop. However, I do not think that a settings at the bottom of the page
is a reasonable solution for a stable feature...people look in 'settings'
menus.

[...] However, I do not think that a settings at the bottom of the page is a reasonable solution for a stable feature...people look in 'settings' menus.

Agreed.
There have been a few ideas about how to give some minimal set of preferences to logged-out users, particularly those around accessibility. I threw together a wireframe and many notes a while ago. An older version contained "Enable popups" - see https://upload.wikimedia.org/wikipedia/commons/archive/4/4b/20141012182140!Wireframe_of_Appearance_menu.png - I only took it out to give a simpler MVP version of the idea. ;-) The latest (simplified) version is on phab at M17. Also, at the Lyon hackathon, May and Prateek worked on a potential-gadget version, and you can see code-details and screencast-video at T91201#1652404

dr0ptp4kt moved this task from Backlog to Next Up on the Reading-Admin board.Nov 21 2015, 12:13 AM
Sumit added a subscriber: Sumit.Dec 11 2015, 5:12 PM
ovasileva closed this task as Invalid.Nov 14 2016, 6:23 PM
ovasileva added a subscriber: ovasileva.

feature already exists, live on beta