Page MenuHomePhabricator

Fix LanguageConverter's parsing
Closed, ResolvedPublic

Description

The manner (and stage of execution) in which LanguageConverter's parsing has been implemented leads to XSS vulnerabilities. Extensions that run prior to LanguageConverter may allow for insertion of partial markup, which is then completed with LanguageConverter content replacement.

These problems may be remediated in two ways:

  1. Modify the stage at which LanguageConverter runs, such that it happens prior to content escaping; and
  2. Improve LanguageConverter's HTML tag parsing so that tag detection does not end early [implemented in LanguageConverter->autoConvert()].

The following bugs are related to this issue and give additional background:

Event Timeline

dpatrick claimed this task.
dpatrick raised the priority of this task from to Needs Triage.
dpatrick updated the task description. (Show Details)
dpatrick changed the visibility from "Public (No Login Required)" to "Custom Policy".
dpatrick changed the edit policy from "All Users" to "Custom Policy".
dpatrick changed Security from None to Software security bug.
dpatrick subscribed.
Bawolff claimed this task.
Bawolff subscribed.

LanguageConverter is better now (but still terrible. Please can we kill it)

Bawolff changed the visibility from "Custom Policy" to "Public (No Login Required)".Sep 4 2018, 3:02 PM
Bawolff changed the edit policy from "Custom Policy" to "All Users".