Page MenuHomePhabricator
Create Task
Maniphest T118815

Remove vendor prefixes from linear-gradient SVG/PNG fallback hack
Closed, ResolvedPublic
Actions

Description

Embedding every SVG twice results in filesize bloat (despite gzip) and adds CPU load to under powered devices.

Very few browsers support linear-gradient only with a vendor prefix (http://caniuse.com/#search=linear-gradient), mainly old versions of Android. For desktop it is 1 or 2 percent. I we remove the vendor prefixes, all these browsers will gracefully fall back to PNG icons.

Details

SubjectRepoBranchLines +/-
Remove vendor prefix support for SVG embeddingmediawiki/coremaster+0 -2
Remove vendor prefix support for SVG embeddingmediawiki/corewmf/1.27.0-wmf.6+0 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Nov 17 2015, 2:31 AM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: MediaWiki-ResourceLoader.
Esanders subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 17 2015, 2:31 AM
gerritbot subscribed.Nov 17 2015, 2:32 AM

Change 253539 had a related patch set uploaded (by Esanders):
Remove vendor prefix support for SVG embedding

https://gerrit.wikimedia.org/r/253539

gerritbot added a project: Patch-For-Review.Nov 17 2015, 2:32 AM
Esanders added a project: Performance Issue.Nov 17 2015, 2:33 AM
Esanders set Security to None.
gerritbot added a comment.Nov 17 2015, 2:50 AM

Change 253539 merged by jenkins-bot:
Remove vendor prefix support for SVG embedding

https://gerrit.wikimedia.org/r/253539

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-11-17_(1.27.0-wmf.7)).Nov 17 2015, 3:00 AM
Nikerabbit subscribed.Nov 17 2015, 9:11 AM

Aren't the phones having high dpi screens the ones which benefit from SVG files the most?

gerritbot added a comment.Nov 17 2015, 10:24 AM

Change 253578 had a related patch set uploaded (by Ori.livneh):
Remove vendor prefix support for SVG embedding

https://gerrit.wikimedia.org/r/253578

gerritbot added a comment.Nov 17 2015, 10:25 AM

Change 253578 merged by Ori.livneh:
Remove vendor prefix support for SVG embedding

https://gerrit.wikimedia.org/r/253578

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)).Nov 17 2015, 11:00 AM
Jdforrester-WMF closed this task as Resolved.Nov 17 2015, 11:47 PM
Jdforrester-WMF claimed this task.
thiemowmde mentioned this in T181487: [Task] Remove -webkit-… vendor prefixes from SVG/PNG fallback hacks in Wikibase.Nov 28 2017, 10:44 AM
thiemowmde created subtask T181487: [Task] Remove -webkit-… vendor prefixes from SVG/PNG fallback hacks in Wikibase.
Restricted Application edited projects, added Performance-Team; removed MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)). · View Herald TranscriptNov 28 2017, 10:44 AM
Jdforrester-WMF closed subtask T181487: [Task] Remove -webkit-… vendor prefixes from SVG/PNG fallback hacks in Wikibase as Resolved.Nov 28 2017, 4:57 PM
thiemowmde mentioned this in rEWLE04912cb5dde9: Remove -webkit-… vendor prefix from SVG/PNG fallback hack.Nov 29 2017, 12:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL