Page MenuHomePhabricator

On Jessie, puppet does not start zuul-merger via init scripts
Closed, ResolvedPublic


I have aborted the deployment of a new zuul merger on scandium (T95046) because puppet refuses to start services that are maintained as sysv init scripts. On the server, we applied role::zuul::merger which defines two services which are roughly:


package { 'git-daemon-sysvinit': ensure => present }

service { 'git-daemon':
    ensure     => running,
    enable     => true,
    hasrestart => true,


package { 'zuul': ensure => present }  # does not provide any systemd file

service { 'zuul-merger':
    name       => 'zuul-merger',
    enable     => true,
    hasrestart => true,

I originally though that both git-daemon and zuul-merger had the same issue. Retrying, it works just fine for git-daemon:

Giving it a try on scandium with git-daemon being stopped:

/etc/init.d/git-daemon status
● git-daemon.service - LSB: git-daemon service
   Loaded: loaded (/etc/init.d/git-daemon)
   Active: inactive (dead) since Tue 2015-11-17 16:19:59 UTC; 12s ago
  Process: 23387 ExecStop=/etc/init.d/git-daemon stop (code=exited, status=0/SUCCESS)
  Process: 22529 ExecStart=/etc/init.d/git-daemon start (code=exited, status=0/SUCCESS)

Nov 17 16:05:13 scandium git-daemon[22534]: Ready to rumble
# puppet agent -tv
Notice: /Stage[main]/Contint::Zuul::Git-daemon/Service[git-daemon]/ensure: ensure changed 'stopped' to 'running'

But for the zuul-merger service:

$ /etc/init.d/zuul-merger status
● zuul-merger.service - LSB: Zuul Merger
   Loaded: loaded (/etc/init.d/zuul-merger)
   Active: inactive (dead) since Tue 2015-11-17 16:24:15 UTC; 2s ago
  Process: 28430 ExecStop=/etc/init.d/zuul-merger stop (code=exited, status=0/SUCCESS)
  Process: 21006 ExecStart=/etc/init.d/zuul-merger start (code=exited, status=0/SUCCESS)
# puppet agent -tv
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for scandium.eqiad.wmnet
Info: Applying configuration version '1447777197'
Notice: Finished catalog run in 10.43 seconds

The service is not started :-(

Event Timeline

hashar claimed this task.
hashar raised the priority of this task from to Medium.
hashar updated the task description. (Show Details)
hashar added subscribers: Andrew, hashar, Aklapper.

zuul-merger does not have ensure => running, so we can stop it manually without having puppet to start it in a middle of an operation.

enable => true make sure it is running on server boot.