Able to insert new lines after the cursor (due to broken unicorn position correction)
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Nov 17 2015, 5:54 PM

Project Tags

Referenced Files

None

Subscribers

Description

To reproduce: go to the end of a heading1; press ctrl+i; press space; press enter.
Expected result: Cursor goes into the new empty <p>
Actual result: Cursor does not move: stays above the new empty <p>

Reproduced on Chrome, Safari and Firefox.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Do not skip past adjacent unicorn in different branch node	VisualEditor/VisualEditor	master	+19 -5

Customize query in gerrit

Related Objects

Mentioned Here: rGVED64a932b0a017: Ignore slugs and chimeras when preventing identical re-renderings

Event Timeline

Jdforrester-WMF created this task.Nov 17 2015, 5:54 PM

Jdforrester-WMF raised the priority of this task from to Medium.

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF added projects: VisualEditor, VisualEditor-ContentEditable.

Jdforrester-WMF added subscribers: Jdforrester-WMF, dchan.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2015, 5:54 PM

Also happens if you open pages/h1.html and press End,Ctrl+i,Space,Enter

Bug first appeared in 64a932b0a017d8a12c86a008d7d847d9a8639d91 (bah, my code)

dchan claimed this task.Nov 17 2015, 6:44 PM

dchan set Security to None.

Jdforrester-WMF moved this task from To Triage to TR3: Language support on the VisualEditor board.Nov 17 2015, 8:03 PM

Jdforrester-WMF removed dchan as the assignee of this task.Nov 19 2015, 7:11 PM

dchan renamed this task from Able to insert new lines after the cursor (? due to being on the wrong side of a nail) to Able to insert new lines after the cursor (due to broken unicorn position correction).Nov 20 2015, 4:33 PM

dchan claimed this task.

dchan updated the task description. (Show Details)

The "git bisect" result is misleading: it is correct code that merely unmasks an existing bug in position correction beside unicorns.

Change 254424 had a related patch set uploaded (by Divec):
Do not skip past adjacent unicorn in different branch node

https://gerrit.wikimedia.org/r/254424

gerritbot added a project: Patch-For-Review.Nov 20 2015, 4:39 PM

Jdforrester-WMF edited a custom field.Nov 20 2015, 6:05 PM

dchan updated the task description. (Show Details)Nov 21 2015, 3:31 PM

Jdforrester-WMF closed this task as Resolved.Nov 24 2015, 5:09 PM

Jdforrester-WMF edited projects, added: MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)); removed: Patch-For-Review.

Change 254424 merged by jenkins-bot:
Do not skip past adjacent unicorn in different branch node