Page MenuHomePhabricator

Honor Accept-Language header to set language variant
Closed, DeclinedPublic

Description

When the incoming request has an Accept-Language header set then it should use the same for the backend requests.
This is to ensure that the service responds with the correct strings on wikis which allow different language variants, like zhwiki.

Event Timeline

bearND created this task.Nov 17 2015, 6:28 PM
bearND updated the task description. (Show Details)
bearND raised the priority of this task from to High.
bearND added a project: Mobile-Content-Service.
bearND moved this task to Doing on the Mobile-Content-Service board.
bearND added a subscriber: bearND.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2015, 6:28 PM

This task is not ready to be worked on yet since Parsoid doesn't honor the Accept-Language header either. First we need to see what the outcome of T113002 is.

bearND moved this task from Doing to On hold on the Mobile-Content-Service board.Nov 17 2015, 9:29 PM
Liuxinyu970226 added a subscriber: Liuxinyu970226.
Nemo_bis renamed this task from Honor Accept-Language header to Honor Accept-Language header to set language variant.
Nemo_bis added a subscriber: Nemo_bis.
Nemo_bis assigned this task to Amire80.Jan 24 2016, 10:01 PM

Assigning per https://phabricator.wikimedia.org/T119022#1916790:

"Amir: Define the desired behavior from the user perspective according to the suggestion to write in your preferred variant"

Restricted Application added a subscriber: Cosine02. · View Herald TranscriptDec 21 2016, 9:58 AM
bearND closed this task as Declined.Jan 19 2017, 4:55 AM

I think Mobile Content Service should just follow the same approach that is decided in T122942: RFC: Support language variants in the REST API.

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptJan 19 2017, 4:55 AM