Page MenuHomePhabricator
Create Task
Maniphest T118882

Honor Accept-Language header to set language variant
Closed, DeclinedPublic
Actions

Description

When the incoming request has an Accept-Language header set then it should use the same for the backend requests.
This is to ensure that the service responds with the correct strings on wikis which allow different language variants, like zhwiki.

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclinedAmire80T118882 Honor Accept-Language header to set language variant
 ResolvedNoneT113002 Let's discuss LanguageConverter

Event Timeline

• bearND created this task.Nov 17 2015, 6:28 PM
• bearND raised the priority of this task from to High.
• bearND updated the task description. (Show Details)
• bearND added a project: Mobile-Content-Service.
• bearND moved this task to Doing on the Mobile-Content-Service board.
• bearND subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2015, 6:28 PM
• bearND added a subtask: T113002: Let's discuss LanguageConverter.Nov 17 2015, 9:29 PM

This task is not ready to be worked on yet since Parsoid doesn't honor the Accept-Language header either. First we need to see what the outcome of T113002 is.

• bearND moved this task from Doing to On hold on the Mobile-Content-Service board.Nov 17 2015, 9:29 PM
• bearND mentioned this in T118905: App: Avoid using RB routes on zhwiki.Nov 17 2015, 10:05 PM
Liuxinyu970226 set Security to None.Nov 18 2015, 10:55 AM
Liuxinyu970226 subscribed.
Nemo_bis renamed this task from Honor Accept-Language header to Honor Accept-Language header to set language variant.Nov 20 2015, 7:37 AM
Nemo_bis added a project: I18n.
Nemo_bis subscribed.
• bearND mentioned this in T119088: Parsing team: Q3 2015-16 goals planning dependency tracker task.Nov 21 2015, 12:18 AM
Nemo_bis assigned this task to Amire80.Jan 24 2016, 10:01 PM

Assigning per https://phabricator.wikimedia.org/T119022#1916790:

"Amir: Define the desired behavior from the user perspective according to the suggestion to write in your preferred variant"

Nemo_bis closed subtask T113002: Let's discuss LanguageConverter as Resolved.Jan 24 2016, 10:02 PM
Shizhao added a subtask: T125033: [DO NOT USE] Chinese Wikimedia projects (tracking) [superseded by #Chinese-Sites].Jan 28 2016, 2:17 AM
Liuxinyu970226 removed a subtask: T125033: [DO NOT USE] Chinese Wikimedia projects (tracking) [superseded by #Chinese-Sites].Jan 28 2016, 4:02 AM
Liuxinyu970226 added a parent task: T125033: [DO NOT USE] Chinese Wikimedia projects (tracking) [superseded by #Chinese-Sites].
Aklapper added a project: Chinese-Sites.Dec 21 2016, 9:58 AM
Restricted Application added a subscriber: Stang. · View Herald TranscriptDec 21 2016, 9:58 AM
Aklapper removed a parent task: T125033: [DO NOT USE] Chinese Wikimedia projects (tracking) [superseded by #Chinese-Sites].Dec 21 2016, 10:03 AM
Shizhao moved this task from Backlog to Extensions/Skins on the Chinese-Sites board.Dec 27 2016, 2:47 AM
• bearND closed this task as Declined.Jan 19 2017, 4:55 AM

I think Mobile Content Service should just follow the same approach that is decided in T122942: RFC: Support language variants in the REST API.

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptJan 19 2017, 4:55 AM
Liuxinyu970226 moved this task from Extensions/Skins to Closed on the Chinese-Sites board.Feb 18 2017, 3:24 AM
Stang unsubscribed.Nov 4 2021, 4:28 PM
Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptNov 4 2021, 4:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL