Page MenuHomePhabricator
Create Task
Maniphest T119053

Uploads fail with verification-error due to incorrect timeout handling
Closed, ResolvedPublic
Actions

Description

GWT returns the following error:
10:13, 19 November 2015 Swiss National Library (talk | contribs) mediafile job failed. Metadata record 2. <verification-error> original URL: http://upload-glam.wikimedia.ch/Gugelmann/GS-GUGE-FREUDENBERGER-A-1.tif evaluated URL: http://upload-glam.wikimedia.ch/Gugelmann/GS-GUGE-FREUDENBERGER-A-1.tif.

tried it twice with the same xml-file, today and yesterday

Yesterday it returned the following error:
15:20, 18 November 2015 Swiss National Library (talk | contribs) mediafile job failed. Metadata record 3. This file did not pass file verification. original URL: http://upload-glam.wikimedia.ch/Gugelmann/GS-GUGE-FREUDENBERGER-A-1.tif evaluated URL: http://upload-glam.wikimedia.ch/Gugelmann/GS-GUGE-FREUDENBERGER-A-1.tif.

It returns the same error for all pictures linked in the xml.
Uesed xml ist the folowing:

GugelmannNov2015.xml8 KBDownload

Pictures are uploaded here: http://upload-glam.wikimedia.ch/Gugelmann

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/GWToolsetmaster+3 -38Fixed verification-error due to incorrect timeout handling
Customize query in gerrit

Related Objects
Search...

Event Timeline

Swiss-National-Library created this task.Nov 19 2015, 10:33 AM
Swiss-National-Library raised the priority of this task from to Needs Triage.
Swiss-National-Library updated the task description. (Show Details)
Swiss-National-Library added a project: MediaWiki-extensions-GWToolset.
Swiss-National-Library added subscribers: Swiss-National-Library, Kelson.
Restricted Application added projects: Multimedia, Commons. · View Herald TranscriptNov 19 2015, 10:33 AM
Restricted Application added subscribers: StudiesWorld, Steinsplitter, Aklapper. · View Herald Transcript
Swiss-National-Library updated the task description. (Show Details)Nov 19 2015, 10:41 AM
Swiss-National-Library set Security to None.
Restricted Application added a subscriber: Matanya. · View Herald TranscriptNov 19 2015, 10:41 AM
zhuyifei1999 moved this task from Incoming to Uploading (Special:Upload) on the Commons board.Nov 19 2015, 11:35 AM
zhuyifei1999 moved this task from Uploading (Special:Upload) to Uploading on the Commons board.
zhuyifei1999 added a subscriber: zhuyifei1999.
Kelson awarded a token.Dec 9 2015, 12:41 PM
MarkTraceur triaged this task as Medium priority.Dec 21 2015, 9:35 PM
MarkTraceur added a subscriber: MarkTraceur.
Kelson added a comment.Dec 23 2015, 5:02 PM

I have tried to reproduce that bug with an ever simplified version of the XML including only the row with "GS-GUGE-FREUDENBERGER-A-1". In my case it fails too with an other error:

17:46, 23 December 2015 Kelson (talk | contribs) mediafile job failed. Metadata record 1. HTTP request timed out. original URL: http://upload-glam.wikimedia.ch/Gugelmann/GS-GUGE-FREUDENBERGER-A-1.tif evaluated URL: http://upload-glam.wikimedia.ch/Gugelmann/GS-GUGE-FREUDENBERGER-A-1.tif.

I have reproduced the problem many times and I can see server side that everything goes right up to 90s after the beginning of the GET request. Then the transfer is stopped, probably by Mediawiki. It looks like that the overall request max lifetime for this download-by-url seems to be set to 90s and is obviously too short. We are as a consequence impacted by T86024.

Kelson added a subtask: T86024: "HTTP request timed out" for large files.Dec 23 2015, 5:03 PM
Kelson added a subscriber: Bawolff.Dec 23 2015, 5:19 PM

We should really try to fix this in the next times because we have a whole GLAM upload/GLAM partner stuck because of that bug.

Bawolff-alt added a project: good first task.Dec 27 2015, 3:40 AM
Bawolff-alt added a subscriber: Bawolff-alt.

There's a bug in WikiChecks::increaseHTTPTimeout().

It increases the timeout incorrectly. As a result the wrong timeout is applied to gwtoolset. Thus when we set the other timeouts to 90 seconds, it started overriding gwtoolset's limit, which its not supposed to.

Instead gwtoolset should pass its custom limit to fetchFile() method of UploadFromUrl (Which it calls from UploadHandler::uploadMediaFileViaUploadFromUrl() ). GWToolset should not try to override global variables.

Kelson added a comment.Dec 28 2015, 7:18 PM

@Bawolff
Thank you very much for your feedback and your analysis on that bug. Do you think you or someone else will get a chance to fix it within a few weeks? Would that be complicated?

Nemo_bis added a project: Google-Code-In-2015.Jan 7 2016, 9:02 PM
Nemo_bis renamed this task from GWT <verification-error> to Uploads fail with verification-error due to incorrect timeout handling.Jan 8 2016, 7:15 AM
Nemo_bis moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.
Mhutti1 claimed this task.Jan 8 2016, 10:37 AM
Kelson added a comment.Jan 8 2016, 12:25 PM

@mhutti

Really surprising to see you there too! But would be really really helpful if you achieved to deal with that we have at least two GLAM institutions currently stuck/braked in their upload project due to that bug. Feel free to contact me if you need a tester.

Mhutti1 added a comment.Jan 8 2016, 12:42 PM

@Kelson yeah I like mixing up the tasks I do :). Once there are some non-beginner kiwix tasks I will do some more of those :)

Nemo_bis added a subscriber: Nemo_bis.Jan 8 2016, 2:41 PM

Great, I've added Kelson to mentors then. :) https://codein.withgoogle.com/dashboard/tasks/6399626554900480/

gerritbot added a subscriber: gerritbot.Jan 8 2016, 9:47 PM

Change 263142 had a related patch set uploaded (by Mhutti1):
Fixed verification-error due to incorrect timeout handling

https://gerrit.wikimedia.org/r/263142

gerritbot added a project: Patch-For-Review.Jan 8 2016, 9:47 PM
gerritbot added a comment.Jan 9 2016, 4:15 PM

Change 263142 merged by jenkins-bot:
Fixed verification-error due to incorrect timeout handling

https://gerrit.wikimedia.org/r/263142

Mhutti1 closed this task as Resolved.Jan 9 2016, 4:20 PM
Kelson mentioned this in T86024: "HTTP request timed out" for large files.Jan 9 2016, 4:21 PM
Mhutti1 closed subtask T86024: "HTTP request timed out" for large files as Resolved.Jan 9 2016, 4:23 PM
Nemo_bis merged a task: T86024: "HTTP request timed out" for large files.Jan 9 2016, 4:23 PM
Nemo_bis added subscribers: Tgr, Fae, Lokal_Profil and 2 others.
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Jan 9 2016, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL