Page MenuHomePhabricator
Create Task
Maniphest T119075

Template: Input for template name always marked as invalid, even if template exist
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

See image:

Unbenannt.PNG (490×501 px, 11 KB)

Steps to reproduce:

  • Open a page on mediawiki.org
  • Start editing with VE (using the "Edit" button)
  • Click "Insert" -> "Template" or type "{{" to open the Template dialog
  • Type in the name of an existing template into the template name input box or select the name of the suggestions

Expected result:
The input box has a blue indicator

Observed result:
The input box has a red indicator, which should indicate, that the template currently does not exist.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix conflicting configuration name in TitleInputWidgetmediawiki/corewmf/1.27.0-wmf.7+10 -9
Fix conflicting configuration name in TitleInputWidgetmediawiki/coremaster+10 -9
Customize query in gerrit

Event Timeline

Florian created this task.Nov 19 2015, 2:31 PM
Florian raised the priority of this task from to Needs Triage.
Florian updated the task description. (Show Details)
Florian added a project: VisualEditor.
Florian subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 19 2015, 2:31 PM
Florian added a project: OOUI.Nov 19 2015, 5:47 PM

Adding OOUI, it seems to be a problem with the latest release, because I see this on Special:MovePage, too. For the new title input, which should never be red.

Florian added subscribers: matmarex, Jdforrester-WMF.Nov 19 2015, 5:47 PM
Krenair subscribed.Nov 19 2015, 8:14 PM

Looks like the validation function isn't being set up properly

Krenair added a comment.EditedNov 19 2015, 8:38 PM

Due to the order in which we call mw.widgets.TitleInputWidget.parent and mw.widgets.TitleWidget in mw.widgets.TitleInputWidget's constructor
Edit: Well, not quite.

Krenair edited projects, added VisualEditor-MediaWiki, MediaWiki-User-Interface; removed OOUI.Nov 19 2015, 8:39 PM
Krenair set Security to None.
Florian claimed this task.Nov 19 2015, 9:19 PM
Jdforrester-WMF triaged this task as High priority.Nov 19 2015, 9:20 PM
Jdforrester-WMF added a subscriber: DLynch.
gerritbot subscribed.Nov 19 2015, 9:23 PM

Change 254296 had a related patch set uploaded (by Florianschmidtwelzow):
Fix conflicting configuration name in TitleInputWidget

https://gerrit.wikimedia.org/r/254296

gerritbot added a project: Patch-For-Review.Nov 19 2015, 9:23 PM
gerritbot added a comment.Nov 19 2015, 9:45 PM

Change 254296 merged by jenkins-bot:
Fix conflicting configuration name in TitleInputWidget

https://gerrit.wikimedia.org/r/254296

gerritbot added a comment.Nov 19 2015, 9:49 PM

Change 254307 had a related patch set uploaded (by Florianschmidtwelzow):
Fix conflicting configuration name in TitleInputWidget

https://gerrit.wikimedia.org/r/254307

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)).Nov 19 2015, 10:00 PM
gerritbot added a comment.Nov 20 2015, 1:16 AM

Change 254307 merged by jenkins-bot:
Fix conflicting configuration name in TitleInputWidget

https://gerrit.wikimedia.org/r/254307

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-17_(1.27.0-wmf.7)).Nov 20 2015, 2:00 AM
Jdforrester-WMF closed this task as Resolved.Nov 20 2015, 3:11 AM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Dec 3 2015, 1:11 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits