Page MenuHomePhabricator
Create Task
Maniphest T119153

QuickSurveys: Add sessionId to Schema:QuickSurveysResponses
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Having a QuickSurvey is awesome.
Collecting answers is awesome.

But it would be more awesome if the Analytics team can relate these answers to the data being collected elsewhere.

What is not sessionId ?
It is not the user name or any private information.

What is sessionId ?
The sessionId is a random id generated in some location, to mark that some events belong to the same user. It allows single events to be grouped in order to represent an actual user experience.

What is the difference?
The goal is not to identify a user, the goal is to relate an answer to other events, anonymously.

Details

SubjectRepoBranchLines +/-
Add optional sessionId param to QuickSurveysResponsesmediawiki/extensions/QuickSurveysdev+68 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

• JGirault created this task.Nov 20 2015, 12:11 AM
• JGirault claimed this task.
• JGirault raised the priority of this task from to Needs Triage.
• JGirault updated the task description. (Show Details)
• JGirault added projects: Discovery-ARCHIVED, Discovery-Portal-Sprint, QuickSurveys.
• JGirault subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 20 2015, 12:11 AM
• Tbayer subscribed.Nov 20 2015, 7:58 AM

See also T119146

• JGirault moved this task from Backlog to nothing to see here - delete me please on the Discovery-Portal-Sprint board.Nov 20 2015, 10:29 PM
gerritbot subscribed.Nov 20 2015, 10:57 PM

Change 254596 had a related patch set uploaded (by JGirault):
Adds an optional sessionId param to the QuickSurveysResponses schema, and adds an JavaScript API to dynamically set this sessionID (note that it can only be set dynamically after the initial configuration array as it is unique).

https://gerrit.wikimedia.org/r/254596

gerritbot added a project: Patch-For-Review.Nov 20 2015, 10:57 PM
• JGirault added a comment.Nov 20 2015, 11:03 PM

If the patch is approved, adding the sessionId to the data being sent by QuickSurveys would be as simple as adding this to the searchSatisfaction code:

if ( mw.extQuickSurveys ) {
	mw.extQuickSurveys.lib.sessionId.set( 'search-satisfaction', searchSessionId );
}
• JGirault moved this task from nothing to see here - delete me please to Needs code review on the Discovery-Portal-Sprint board.Nov 20 2015, 11:04 PM
• JGirault added a parent task: T118800: QuickSurveys: Add survey on article page when coming from a wiki search.
Jdlrobson triaged this task as Medium priority.Dec 3 2015, 5:58 PM
Jdlrobson subscribed.
• JGirault set Security to None.Dec 9 2015, 10:53 PM
• JGirault edited a custom field.
• JGirault moved this task from Needs code review to Backlog on the Discovery-Portal-Sprint board.Dec 15 2015, 7:36 PM
• Deskana moved this task from Needs triage to On Sprint Board on the Discovery-ARCHIVED board.Dec 30 2015, 10:04 PM
debt renamed this task from Add sessionId to Schema:QuickSurveysResponses to QuickSurveys: Add sessionId to Schema:QuickSurveysResponses.Jan 28 2016, 4:49 PM
debt subscribed.Jan 29 2016, 6:31 PM

closing this out - the work has already been done.

debt closed this task as Resolved.Jan 29 2016, 6:31 PM
debt moved this task from Backlog to Done on the Discovery-Portal-Sprint board.Feb 2 2016, 11:49 PM
debt moved this task from Done to Completed on the Discovery-Portal-Sprint board.Feb 4 2016, 11:14 PM
gerritbot added a comment.Apr 7 2016, 1:03 PM

Change 254596 abandoned by JGirault:
Add optional sessionId param to QuickSurveysResponses

Reason:
We don't need this patch anymore, it's been implemented differently.

https://gerrit.wikimedia.org/r/254596

Ironholds mentioned this in rEQScf50b1788443: Add optional sessionId param to QuickSurveysResponses.Apr 28 2016, 6:22 AM
• JGirault mentioned this in rEQS84c27f8935d8: Adds an optional sessionId param to the QuickSurveysResponses schema, and….Apr 28 2016, 6:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL