Page MenuHomePhabricator

Move echo tables from local wiki databases onto extension1 cluster for mediawikiwiki, metawiki, and officewiki
Closed, DeclinedPublic

Description

InitialiseSettings.php
// Use extension1 db for all wikis
'wmgEchoCluster' => array(
	'default' => 'extension1',
	// The following wikis should be using extension1 db but started with
	// the application main database, stick with the current setting
	'labswiki' => false,
	'mediawikiwiki' => false,
	'metawiki' => false,
	'officewiki' => false,
),
`

labswiki aka wikitech is special and probably needs to stay separate. But mediawikiwiki, metawiki, and officewiki should be moved to the extension1 cluster.

The following tables need to be moved:

  • echo_email_batch
  • echo_event
  • echo_notification
  • echo_target_page

Marking as lowest priority as this is probably difficult and has little gains except for standardization and developer sanity. Just filing this so we don't forget about it.

Related Objects

StatusSubtypeAssignedTask
DeclinedNone
ResolvedMarostegui
ResolvedLadsgroup
ResolvedNone
ResolvedMarostegui
ResolvedMarostegui
ResolvedMarostegui
ResolvedMarostegui
ResolvedMarostegui
ResolvedMarostegui
ResolvedReedy
ResolvedMarostegui
ResolvedMarostegui
ResolvedMarostegui
DeclinedNone
ResolvedMarostegui
ResolvedMarostegui
ResolvedLadsgroup
ResolvedMarostegui
ResolvedMarostegui
ResolvedMarostegui
ResolvedMarostegui
ResolvedMarostegui
ResolvedMarostegui
ResolvedMarostegui
ResolvedLadsgroup
ResolvedMarostegui
ResolvedMarostegui
ResolvedLadsgroup
ResolvedKormat
ResolvedMarostegui
ResolvedKormat
ResolvedMarostegui
ResolvedKormat
OpenNone
ResolvedMarostegui
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone

Event Timeline

Legoktm raised the priority of this task from to Lowest.
Legoktm updated the task description. (Show Details)
Legoktm added a subscriber: Legoktm.

I was one of the people that wouldn't understand why this was like this in the first place, but: Are we sure this is the way to go, and that the original reasons, whatever they were, are not relevant anymore?

For example, labswiki is believed to be wanted to be isolated for availability reasons. Is there consensus on this?

Once that is clear, I have no technical reason to not put this on the backlog.

I was one of the people that wouldn't understand why this was like this in the first place, but: Are we sure this is the way to go, and that the original reasons, whatever they were, are not relevant anymore?

The original "reasons" is that Echo was deployed to those wikis before it was realized we needed/should use the extension1 cluster (I can dig up the history if you want, but I wasn't involved at that time). Originally just large and medium wikis were on extension1, but then we realized T58222: Wikis get bigger (surprise, surprise!), so *all* wikis were moved to extension1, except for the four remaining exceptions. I don't know what the rationale for not moving those at the time were. I'll do some more research to figure out why...

For example, labswiki is believed to be wanted to be isolated for availability reasons. Is there consensus on this?

The labswiki database should stay where it is, and *not* be moved to extension1. I intentionally did not include it in the bug title.

My mistake, I assumed labswiki was part of the migration just because it was part of the configuration.

Change 547553 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/mediawiki-config@master] labtestwikitech: use local database for Echo

https://gerrit.wikimedia.org/r/547553

Attached patch is regarding labtestwikitech -- pretty much any changes made for wikitech need to be made there too.

Change 547553 abandoned by Andrew Bogott:
labtestwikitech: use local database for Echo

Reason:
dropping in favor of the much-more-expansive https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/ /547596/

https://gerrit.wikimedia.org/r/547553

LSobanski added a subscriber: LSobanski.

We consider this task to be very risky and with the limited gain suggest against going forward with it. Closing, please reach out to me directly if you would like to discuss this.