Page MenuHomePhabricator

Delete topics/board while another user tries to edit - a user gets confusing error messages
Open, Needs TriagePublic

Description

Since the present behavior for the issue is different, the updated description is provided below.
The previous description of the issue is moved to Comments.

Two cases - 1) a topic was deleted when another user attempt to post/add new topic 2) The Flow board (a page was deleted).

The topic was deleted.

  • First user deletes a topic while another user was viewing the topic (the topic is displayed on the second user screen).
  • The second user attempts to add a new topic or a new post. For a new topic the error message displays confusing 'vppermissions'; for adding a post the error message is ok.

Note: there are no other, previously reported issues - i.e. 'dimmed' drop-down menu, odd 'discard exchanges' VE pop-up, or 'Conversion from 'topic-title-wikitext' to 'html' was requested...'.

A Flow board was deleted.

  • the second user attempting to add a new topic or a post, will see "Page provided does not have Flow enabled and safeAllowCreation failed with: User does not have the "Create Flow boards in any location" permission" - which is misleading

Event Timeline

Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added a subscriber: Etonkovidova.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 20 2015, 12:48 AM
Etonkovidova renamed this task from Deleted topics/board while another user tries to edit - a user gets confusing error messages to Delete topics/board while another user tries to edit - a user gets confusing error messages.Nov 20 2015, 12:49 AM
Etonkovidova set Security to None.

I don't see the topic-title-wikitext message. (I didn't know exactly how to reproduce since it just says "a non-privileged user attempts to edit or to post a reply to a deleted topic").

But anyway, there are still issues here (e.g. edit-topic-title or edit-post "An error occurred. The error message received was: vppermissions")

It still lets you try to save in this situation which triggers another message ("The prev_revision parameter must be set").

Someone can check again for the topic-title-wikitext after the rest is fixed and this goes to QA.

Etonkovidova updated the task description. (Show Details)Apr 28 2016, 7:56 PM

Previous description of the issue - moved to Comments since the current behavior is different.

While verifying T116095: Ensure users can not access topics from deleted boards via Varnish caching found this edge case:

  1. Log in as a non-privileged user and go to any Flow board page.
  1. Log in as Admin and go to the same Flow page that a non-privileged user is currently viewing.
  1. Admin deletes a topic - a non-privileged user attempts to edit or to post a reply to a deleted topic. A user receives quite few error messages (some of them malformed) and none of them is helpful.

Exception Caught: Conversion from 'topic-title-wikitext' to 'html' was requested, but this is not supported.

Edit a previous post: An error occurred.<br />The error message received was: internal_api_error_Flow\Exception\WikitextException

The UI displays weird messages - 'changes' become 'exchanges'

(Can not reproduce the topic-title-wikitext part)

a dimmed, transculent menu

  1. If a Flow board was deleted while another user session is still active - a warning ( little bit cryptic) is displayed:
Page provided does not have Flow enabled and allowCreation failed with: User does not have the "Create Flow boards in any location" permission

Console shows: Uncaught TypeError: Cannot read property 'view-post' of undefined