Page MenuHomePhabricator
Create Task
Maniphest T119253

Remove BatchRowUpdate from Flow and Echo and use the one in MediaWiki core instead
Closed, ResolvedPublic
Actions

Description

Replace EchoBatchRowUpdate usage with BatchRowUpdate from core. Same for accompanying classes.

The Echo version is used in other extensions (at least Flow); they have to be replaced before the removal is merged.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace EchoBatchRowUpdate with BatchRowUpdatemediawiki/extensions/Echomaster+7 -715
Replace EchoBatchRowUpdate with BatchRowUpdatemediawiki/extensions/Flowmaster+67 -42
Replace EchoBatchRowUpdate with BatchRowUpdatemediawiki/extensions/Flowmaster+25 -33
Customize query in gerrit

Event Timeline

• Mattflaschen-WMF created this task.Nov 20 2015, 11:26 PM
• Mattflaschen-WMF raised the priority of this task from to Needs Triage.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF added projects: good first task, Google-Code-In-2015.
• Mattflaschen-WMF subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 20 2015, 11:26 PM
• Mattflaschen-WMF added a project: Notifications (Echo).Nov 20 2015, 11:32 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptNov 20 2015, 11:32 PM
• Mattflaschen-WMF updated the task description. (Show Details)Nov 20 2015, 11:39 PM
• Mattflaschen-WMF added a project: StructuredDiscussions.
• Mattflaschen-WMF set Security to None.
Aklapper added a comment.Dec 5 2015, 7:38 PM

Could not find any other affected MediaWiki extensions at least in Wikimedia Git repositories:

$:andre\> pwd
/home/foo/wikimedia/git/mediawiki-extensions
$:andre\> grep -r "EchoBatchRowUpdate" .
./Echo/autoload.php:	'EchoBatchRowUpdate' => __DIR__ . '/includes/BatchRowUpdate.php',
./Echo/maintenance/updateEchoSchemaForSuppression.php:		$updater = new EchoBatchRowUpdate(
./Echo/includes/BatchRowUpdate.php: *   $updater = new EchoBatchRowUpdate(
./Echo/includes/BatchRowUpdate.php: * An example maintenance script utilizing the EchoBatchRowUpdate can be located in the Echo
./Echo/includes/BatchRowUpdate.php:class EchoBatchRowUpdate {
./Flow/maintenance/FlowUpdateWorkflowPageId.php:		$updater = new EchoBatchRowUpdate( $it, $writer, $gen );
./Flow/maintenance/FlowFixWorkflowLastUpdateTimestamp.php:		$updater = new EchoBatchRowUpdate(
./Flow/maintenance/FlowFixLog.php:		$updater = new EchoBatchRowUpdate(
./Flow/maintenance/FlowExternalStoreMoveCluster.php:        $updater = new EchoBatchRowUpdate(
Aklapper renamed this task from Remove BatchRowUpdate and use the core one instead to Remove BatchRowUpdate from Flow and Echo and use the one in MediaWiki core instead.Dec 5 2015, 7:45 PM
Aklapper added a comment.Dec 5 2015, 8:16 PM

Imported as https://codein.withgoogle.com/dashboard/tasks/5124898120794112/

Aklapper moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.Dec 5 2015, 8:16 PM
Sn1per claimed this task.Dec 14 2015, 7:25 PM
gerritbot subscribed.Dec 15 2015, 9:35 PM

Change 259397 had a related patch set uploaded (by Sn1per):
Replace FlowBatchRowUpdate with BatchRowUpdate

https://gerrit.wikimedia.org/r/259397

gerritbot added a project: Patch-For-Review.Dec 15 2015, 9:35 PM
gerritbot added a comment.Dec 15 2015, 10:05 PM

Change 259405 had a related patch set uploaded (by Sn1per):
Replace EchoBatchRowUpdate with BatchRowUpdate

https://gerrit.wikimedia.org/r/259405

gerritbot added a comment.Dec 15 2015, 10:06 PM

Change 259406 had a related patch set uploaded (by Sn1per):
Replace EchoBatchRowUpdate with BatchRowUpdate

https://gerrit.wikimedia.org/r/259406

gerritbot added a comment.Dec 15 2015, 10:07 PM

Change 259405 abandoned by Sn1per:
Replace EchoBatchRowUpdate with BatchRowUpdate

Reason:
Change-Id mixup

https://gerrit.wikimedia.org/r/259405

gerritbot added a comment.Dec 22 2015, 11:32 PM

Change 259406 merged by jenkins-bot:
Replace EchoBatchRowUpdate with BatchRowUpdate

https://gerrit.wikimedia.org/r/259406

gerritbot added a comment.Dec 22 2015, 11:32 PM

Change 259397 merged by jenkins-bot:
Replace EchoBatchRowUpdate with BatchRowUpdate

https://gerrit.wikimedia.org/r/259397

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Dec 23 2015, 12:00 AM
Sn1per closed this task as Resolved.Dec 23 2015, 4:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits