Page MenuHomePhabricator
Create Task
Maniphest T119430

External link node doesn't render in reference context
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

pasted_file (688×229 px, 24 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Create MWPreviewElement which adds the mw-body-content classEsandersmediawiki/extensions/VisualEditormaster+32 -3
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Nov 23 2015, 8:17 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added projects: VisualEditor, VisualEditor-MediaWiki, VisualEditor-MediaWiki-References.
Esanders subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 23 2015, 8:17 PM
gerritbot subscribed.Nov 23 2015, 10:30 PM

Change 255031 had a related patch set uploaded (by Esanders):
Create MWPreviewElement which adds the mw-body-content class

https://gerrit.wikimedia.org/r/255031

gerritbot added a project: Patch-For-Review.Nov 23 2015, 10:30 PM
Esanders added a comment.Nov 23 2015, 10:35 PM

The above patch also fixes the font size of reference contexts:

interface size (before)content size (after)
pasted_file (531×214 px, 36 KB)
pasted_file (529×213 px, 37 KB)

It looked a little odd at first but I think this is more correct...

gerritbot added a comment.Nov 23 2015, 11:04 PM

Change 255031 merged by jenkins-bot:
Create MWPreviewElement which adds the mw-body-content class

https://gerrit.wikimedia.org/r/255031

Jdforrester-WMF closed this task as Resolved.Nov 23 2015, 11:21 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)).Nov 24 2015, 12:00 AM
Jdforrester-WMF moved this task from To Triage to Needs Discussion/Analysis on the VisualEditor board.Dec 3 2015, 1:11 AM
Krinkle mentioned this in T279388: ResourceLoaderSkinModule: Improve the content-parser-output module.May 5 2021, 6:28 PM
Krinkle mentioned this in T281540: External links icons are missing on special pages and various secondary content when using ResourceLoaderSkinModule.May 5 2021, 7:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits