Page MenuHomePhabricator
Create Task
Maniphest T119437

iOS 8 Visual regressions in article cards - titles sometimes truncating to one line and extra description padding
Closed, ResolvedPublic
Actions

Assigned To
Mhurd
Authored By
Mhurd
Nov 23 2015, 8:46 PM
Tags
Referenced Files
F3014458: IMG_0411.PNG
Nov 25 2015, 10:02 PM
F3014462: IMG_0095.PNG
Nov 25 2015, 10:02 PM
F3014475: IMG_0093.PNG
Nov 25 2015, 10:02 PM
F3014454: IMG_0414.PNG
Nov 25 2015, 10:02 PM
F3014455: IMG_0413.PNG
Nov 25 2015, 10:02 PM
F3014477: IMG_0092.PNG
Nov 25 2015, 10:02 PM
F3014464: IMG_0094.PNG
Nov 25 2015, 10:02 PM
F3009009: Screen Shot 2015-11-23 at 3.51.52 PM.png
Nov 23 2015, 11:54 PM
View All 11 Files
Subscribers
Aklapper
Etonkovidova
• JMinor
Mhurd
StudiesWorld

Description

Screen Shot 2015-11-23 at 12.43.33 PM.png (1×2 px, 579 KB)

Screen Shot 2015-11-23 at 12.33.22 PM.png (1×2 px, 938 KB)

Screen Shot 2015-11-23 at 3.51.52 PM.png (1×974 px, 611 KB)

Perhaps related - nearby cell isn't truncating *or* wrapping title, it's just cutting it off...

Screen Shot 2015-11-23 at 2.45.24 PM.png (1×974 px, 248 KB)

Related Objects

Event Timeline

Mhurd created this task.Nov 23 2015, 8:46 PM
Mhurd raised the priority of this task from to Needs Triage.
Mhurd updated the task description. (Show Details)
Mhurd added a project: Wikipedia-iOS-App-Development.
Mhurd moved this task to Tasks from Product Backlog on the Wikipedia-iOS-App-Development board.
Mhurd subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 23 2015, 8:46 PM
Mhurd renamed this task from Visual regression in article cards - titles sometimes truncating to one line and extra description padding to iOS 8 Visual regression in article cards - titles sometimes truncating to one line and extra description padding.Nov 23 2015, 8:51 PM
Mhurd set Security to None.
Mhurd added a comment.Nov 23 2015, 8:59 PM

I didn't test this in iOS 9 - may or may not manifest there as well...

Mhurd renamed this task from iOS 8 Visual regression in article cards - titles sometimes truncating to one line and extra description padding to iOS 8 Visual regressions in article cards - titles sometimes truncating to one line and extra description padding.Nov 23 2015, 10:47 PM
Mhurd updated the task description. (Show Details)
Mhurd added a comment.EditedNov 23 2015, 10:58 PM

Hmm... interestingly these cells seem to layout properly if you rotate landscape then back to portrait...

Mhurd added a comment.Nov 23 2015, 11:46 PM

Confirmed only happening pre-iOS 9.

Mhurd added a comment.Nov 23 2015, 11:52 PM

Repro steps:

  • use 8.4 simulator
  • set simulator location to apple Debug > Location > Apple
  • start app
  • scroll to nearby in feed
  • first nearby item should be International Federation of Inventor' Associations
  • the title will be incorrectly truncated to International Federation of
  • tap on that entry
  • wait for article to load
  • then tap TOC button and tap "Read more" entry
  • the "Patents" article read-more card will have improperly truncated description
Mhurd updated the task description. (Show Details)Nov 23 2015, 11:54 PM
Mhurd moved this task from Tasks from Product Backlog to Needs Code Review on the Wikipedia-iOS-App-Development board.Nov 23 2015, 11:59 PM
Mhurd added a comment.Nov 24 2015, 12:05 AM

https://github.com/wikimedia/wikipedia-ios/pull/278

Mhurd added a subscriber: • JMinor.Nov 24 2015, 12:14 AM

@JMinor - I found and took a stab at fixing this while I was waiting to hear back from search guys about the disambig exclusion bits...

Mhurd claimed this task.Nov 24 2015, 12:30 AM
• BGerstle-WMF mentioned this in rAPIOSfbd6bf7b2f76: Merge pull request #278 from wikimedia/bug/T119437/iOS8-cell-layout-bug.Nov 25 2015, 5:32 PM
Mhurd moved this task from Needs Code Review to Needs QA on the Wikipedia-iOS-App-Development board.Nov 25 2015, 5:34 PM
Etonkovidova subscribed.Nov 25 2015, 10:02 PM

Checked with 5.0.0.520 on iPad mini iOS 8.2 and spot-check iPhone 5 iOS 9.02.

No ellipsis for one line of text (could not check Nearby). Below are screenshots with long titles

IMG_0414.PNG (2×1 px, 2 MB)

IMG_0413.PNG (2×1 px, 271 KB)

IMG_0411.PNG (2×1 px, 275 KB)

IMG_0095.PNG (640×360 px, 159 KB)

IMG_0094.PNG (1×640 px, 156 KB)

IMG_0093.PNG (1×640 px, 130 KB)

IMG_0092.PNG (1×640 px, 109 KB)

Etonkovidova moved this task from Needs QA to Needs Design Review on the Wikipedia-iOS-App-Development board.Nov 25 2015, 10:03 PM
• Nirzar moved this task from Needs Design Review to Ready for PM Signoff on the Wikipedia-iOS-App-Development board.Nov 26 2015, 12:24 AM
• JMinor closed this task as Resolved.Dec 3 2015, 12:33 AM
• BGerstle-WMF mentioned this in rAPIOS15ffb7b74948: Merge pull request #278 from wikimedia/bug/T119437/iOS8-cell-layout-bug.Dec 28 2015, 9:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL