Page MenuHomePhabricator

When back-clicking with mouse, MMV goes through all images
Closed, DuplicatePublic

Description

Ever since Media Viewer went live I've noticed this behavior when looking at images in Wikipedia:

  • If I am in a Wiki page and click on an image on the right to view it, it opens properly in Media Viewer. I then click ESC to close the image.
  • Then if I click the 'back' button on the left side of my mouse it returns me to the popup image instead of a previous webpage.

May not sound like much but after going through several wiki pages looking at images...when I want to go back to the original page...I have to click through every cached image on the way back.

AN EXAMPLE: Go to https://en.wikipedia.org/wiki/Atacama_Desert and click on a few of the images on the right, closing them with ESC. Then click the back button on the left of the mouse. Kind of clunky.

Event Timeline

Reiver45 created this task.Nov 23 2015, 8:59 PM
Reiver45 updated the task description. (Show Details)
Reiver45 raised the priority of this task from to Needs Triage.
Reiver45 added a subscriber: Reiver45.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 23 2015, 8:59 PM
Krenair added a subscriber: Krenair.

Hi @Reiver45, thanks for taking the time to report this!
Is this one of the issues listed on T78224 ?

Aklapper renamed this task from Media Viewer in Wikipedia- odd behavior when back-clicking with mouse to When back-clicking with mouse, MMV goes through all images.Nov 24 2015, 3:05 PM
Aklapper set Security to None.

Thanks for looking into this. Yes I found the issue on the list you sent. Looks like its an HTML5 limitation, that its creating a history entry when viewing an image. Looks like there's no real workaround unfortunately.

-B

  • Original Message -----

From: "Aklapper" <no-reply@phabricator.wikimedia.org>
To: blittle1@comcast.net
Sent: Tuesday, November 24, 2015 10:04:39 AM
Subject: [Maniphest] [Updated] T119441: Media Viewer in Wikipedia- odd behavior when back-clicking with mouse

Aklapper added a comment.

Hi @Reiver45, thanks for taking the time to report this!
Is this one of the issues listed on https://phabricator.wikimedia.org/T78224 ?

TASK DETAIL
https://phabricator.wikimedia.org/T119441

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Aklapper
Cc: Krenair, Aklapper, Reiver45, StudiesWorld, Fabrice_Florin, Tgr

Thanks for looking into this. Yes I found the issue on the list you sent.

Which one is it exactly?

  • Original Message -----

Please strip unneeded full quoting for the sake of readability.

TheDJ added a subscriber: TheDJ.Nov 24 2015, 3:25 PM

I think this is ticket T64266.

The case was T64266 ( I had sent screenshot, must have been stripped out).

  • Original Message -----

From: "Aklapper" <no-reply@phabricator.wikimedia.org>
To: blittle1@comcast.net
Sent: Tuesday, November 24, 2015 10:24:51 AM
Subject: [Maniphest] [Commented On] T119441: When back-clicking with mouse, MMV goes through all images

Aklapper added a comment.

In https://phabricator.wikimedia.org/T119441#1828099, @Reiver45 wrote:

Thanks for looking into this. Yes I found the issue on the list you sent.

Which one is it exactly?

  • Original Message -----

Please strip unneeded full quoting for the sake of readability.

TASK DETAIL
https://phabricator.wikimedia.org/T119441

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Aklapper
Cc: Krenair, Aklapper, Reiver45, StudiesWorld, Fabrice_Florin, Tgr

@Reiver45: Please strip unneeded full quoting from your emails, for the sake of readability. Thanks again.