Page MenuHomePhabricator

OOUI MediaWiki theme: Some shadows are solid, some are fading
Closed, ResolvedPublic

Description

pasted_file (221×828 px, 14 KB)

After T119462: MediaWiki drop shadows are all over the place, we have two (down from three) styles of shadow:

  1. We have 2px single-shade shadow on dialogs, DropdownWidget and PopupElement:

pasted_file (88×156 px, 1 KB)

  1. We have a blurred/fading shadow in toolbars

pasted_file (108×114 px, 1 KB)

Which do we want?

The proposal from M101 solves it by defining one faded shadow for everything. On the toolbar itself it is a tad lighter to not put too much focus on it.
Additionally it solves the following issue and improves identifiability of those elements a bit by setting a slightly higher contrast:

T155383 dropdown spatial visual appearance _before - OOjs UI Demos 2017-01-15.png (184×173 px, 11 KB)

Event Timeline

Jdforrester-WMF raised the priority of this task from to Medium.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF subscribed.

I think it makes sense to have the first option for toolbars and dropdown widgets. But a faded shadow helps with popup and other dialogs as its more explicitly above everything else.

Change 332179 had a related patch set uploaded (by VolkerE):
MediaWiki theme: Unify box-shadows to one visual appearance

https://gerrit.wikimedia.org/r/332179

Change 332179 merged by jenkins-bot:
MediaWiki theme: Unify box-shadows to one visual appearance

https://gerrit.wikimedia.org/r/332179

Volker_E moved this task from Reviewing to OOjs-UI-0.18.4 on the OOUI board.
Volker_E edited projects, added OOUI (OOjs-UI-0.18.4); removed OOUI.
Volker_E removed a project: Patch-For-Review.