Maniphest T119684

[5.0.0.522] Crash with 3D touch on the picture of the day
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Nov 26 2015, 12:17 AM

Tags

Referenced Files

None

Subscribers

Description

Repro steps

Go to the Home page
Long-press(3D touch) on the picture in Today's picture section. The app crashes.

Related Objects

Mentioned In: rAPIOS0d874b5f0759: Merge pull request #291 from wikimedia/feature/T119684/preview-pod
rAPIOSccf0895e77ea: Merge pull request #291 from wikimedia/feature/T119684/preview-pod
T119668: As a user, I can see the picture of day in my feed

Event Timeline

Etonkovidova created this task.Nov 26 2015, 12:17 AM

Etonkovidova raised the priority of this task from to Needs Triage.

Etonkovidova updated the task description. (Show Details)

Etonkovidova added a project: Wikipedia-iOS-App-Backlog.

Etonkovidova subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 26 2015, 12:17 AM

Etonkovidova mentioned this in T119668: As a user, I can see the picture of day in my feed.Nov 26 2015, 12:18 AM

• JMinor triaged this task as Medium priority.Dec 1 2015, 6:39 PM

• JMinor added a project: iOS-app-v5-beta.

• JMinor set Security to None.

• JMinor edited projects, added Wikipedia-iOS-App-Development; removed Wikipedia-iOS-App-Backlog.

• Fjalapeno claimed this task.Dec 2 2015, 12:33 AM

• Fjalapeno moved this task from Tasks from Product Backlog to Doing on the Wikipedia-iOS-App-Development board.

• Fjalapeno moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Development board.Dec 2 2015, 12:37 AM

• BGerstle-WMF mentioned this in rAPIOSccf0895e77ea: Merge pull request #291 from wikimedia/feature/T119684/preview-pod.Dec 2 2015, 1:12 AM

I'm seeing 3d touch crash on featured article feed card too - seems to be the addProgressView method in WMFArticleContainerViewController

Mhurd added a comment.Dec 2 2015, 1:50 AM

This comment was removed by Mhurd.

Quick fix: https://github.com/wikimedia/wikipedia-ios/pull/293

• Fjalapeno moved this task from Needs Code Review to Needs QA on the Wikipedia-iOS-App-Development board.Dec 2 2015, 4:11 PM

Tested. Follow-on ticket ( https://phabricator.wikimedia.org/T120051 ) fixes all other peek crashes.

Mhurd moved this task from Needs QA to Ready for PM Signoff on the Wikipedia-iOS-App-Development board.Dec 2 2015, 7:20 PM

Can't verify first hand (no 6S) but I trust Monte's testing was thorough...

• BGerstle-WMF mentioned this in rAPIOS0d874b5f0759: Merge pull request #291 from wikimedia/feature/T119684/preview-pod.Dec 28 2015, 9:12 PM